This repository was archived by the owner on Jan 9, 2025. It is now read-only.
Handle scenarios where Lists get ivalid during export#13
Open
Michael-Phoenix wants to merge 1 commit intoCommunityBanList:masterfrom
Open
Handle scenarios where Lists get ivalid during export#13Michael-Phoenix wants to merge 1 commit intoCommunityBanList:masterfrom
Michael-Phoenix wants to merge 1 commit intoCommunityBanList:masterfrom
Conversation
Stop trying to export all ban entries of a specific Export List when that list errors out.
ect0s
reviewed
Sep 11, 2022
Contributor
ect0s
left a comment
ect0s
left a comment
There was a problem hiding this comment.
Would it make sense to double check the database for the specified list, then remove bans/ignore ban/creation/deletion if the last has been removed?
The circumstance where a list is invalid on BM but valid on our end (IN our databse) would require battlemetrics removing a banlist on its own.
In the case where a user logs into the website and deletes their list, we can catch this here and cleanup?
| `Failed to ${ | ||
| exportBan.status === 'TO_BE_CREATED' ? 'create' : 'delete' | ||
| } export ban (ID: ${exportBan.id}): `, | ||
| } export ban (ID: ${exportBan.id}) - Ignoring exports for List ${exportBan.ExportBanList.id} for this run: `, |
Contributor
There was a problem hiding this comment.
Is there a way that this can throw an error in logging so we can take action on it with PM2?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop trying to export all ban entries of a specific Export List when that list errors out.