Repository navigation
chore(paseo): configure worktree lifecycle - #263
Conversation
CompleteDotTech
left a comment
CompleteDotTech
left a comment
There was a problem hiding this comment.
Independent source review at ec2f1f38b0f2920f9234595ffbec054afc66d16b: no blocking findings in the changed scope.
The two incompatible dependency sets are isolated in separate .venv and .venv-rig directories, both ignored by Git. The dispatcher uses platform-correct Python paths and stops on a failed subprocess. I independently executed the literal Python setup command through Windows PowerShell with synthetic empty requirements: both environments were created; removing the second requirements file made setup fail. The browser runner pin narrows the job to Ubuntu 24.04 without removing any test or changing its assertions.
These smoke probes isolate command dispatch and failure behavior; they do not certify full dependency installation, browser behavior, or application correctness. Full package and cross-platform checks remain governed by CI. This is an independent-agent COMMENT review, not a different-account approval or a claim that every required check passed.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Configure Paseo worktree setup/teardown with separate portable Python environments for delivery and 3D rig validation, plus the existing Node tools. The two pinned Python requirement sets conflict when combined, so setup installs them independently into
.venvand.venv-rig; both generated environments are ignored by Git. A Node subprocess dispatcher selects native Python and platform-specific environment paths and propagates failures.The existing 3D browser CI job is pinned to Ubuntu 24.04 because Playwright 1.55 cannot install Chromium on Ubuntu 26.04. Its test command and pinned dependencies are unchanged.
Prior work
No overlapping lifecycle or Playwright/Ubuntu PR was found in the repository searches. These fixes continue the existing lifecycle PR.
Test plan
git check-ignore .venv/pyvenv.cfg .venv-rig/pyvenv.cfg.actionlint .github/workflows/rig-3d.yml, JSON parsing, andgit diff --check.python3.11-venvprerequisite was installed: the exact dispatcher creates both local environments with synthetic empty requirements, and an invalid requirement returns nonzero. No project dependencies were installed globally.ec2f1f38b0f2920f9234595ffbec054afc66d16b: Chromium installation and both browser playback/vertex-comparison jobs. All 27 hosted checks now pass at this head, including full 2D compatibility and public-delivery on Linux, Windows, and macOS.