Fix version in cli #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mab879
force-pushed
the
fix_version
branch
5 times, most recently
from
37748bc to
cc66004
Compare
Member
Author
|
To test you can install the copr |
vojtapolasek
reviewed
Jan 8, 2026
Makefile
Outdated
| .PHONY: build | ||
| build: cvetool | ||
|
|
||
| +VERSION ?= $(shell git describe --tags --match 'v*' --always --dirty 2>/dev/null || echo dev) |
There was a problem hiding this comment.
Suggested change
| +VERSION ?= $(shell git describe --tags --match 'v*' --always --dirty 2>/dev/null || echo dev) | |
| VERSION ?= $(shell git describe --tags --match 'v*' --always --dirty 2>/dev/null || echo dev) |
vojtapolasek
suggested changes
Jan 8, 2026
vojtapolasek
left a comment
vojtapolasek
left a comment
There was a problem hiding this comment.
Please remove the + sign, with it the version does not get propagated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22