Skip to content

Admin page styling#119

Merged
Opeyem1a merged 13 commits into
mainfrom
admin-page-styling
Apr 11, 2022
Merged

Admin page styling#119
Opeyem1a merged 13 commits into
mainfrom
admin-page-styling

Conversation

@ketphan02
Copy link
Copy Markdown
Collaborator

@ketphan02 ketphan02 commented Mar 28, 2022

  • closes Fix admin page styling #97 and Admin header #121
  • update puzzle instances when creating new
  • a clickable map that set can be used to set the address
  • display puzzles
  • display puzzle instances
  • create puzzle instances
  • filter puzzle instances by puzzle
  • have not implemented delete and view puzzle instances
  • apply a new way to export components to index.tsx file (less likely to cause merge conflict with this)

image

image

@ketphan02 ketphan02 added the enhancement New feature or request label Mar 28, 2022
@ketphan02 ketphan02 requested review from Opeyem1a and yuqi88 March 28, 2022 15:14
@ketphan02 ketphan02 self-assigned this Mar 28, 2022
@ketphan02 ketphan02 linked an issue Mar 28, 2022 that may be closed by this pull request
Comment thread src/__mocks__/pages/api/puzzles/index.ts
@ketphan02
Copy link
Copy Markdown
Collaborator Author

There're some tests and mocks were affected by prettify, please ignore them

Comment thread src/components/App/DisplayPuzzleInstances/DisplayPuzzleInstances.module.scss Outdated
Comment thread src/components/App/DisplayPuzzleInstances/index.tsx Outdated
Comment thread src/components/App/DisplayPuzzleInstances/index.tsx Outdated
Comment thread src/components/App/DisplayPuzzleInstances/index.tsx Outdated
Comment thread src/components/App/DisplayPuzzleInstances/index.tsx Outdated
Comment thread src/components/App/PuzzleGenerate/index.tsx Outdated
Comment thread src/components/App/PuzzleGenerate/index.tsx
Comment thread src/components/App/PuzzleGenerate/index.tsx Outdated
Comment thread src/components/App/index.tsx
Comment thread src/components/Global/Input/index.tsx
@ketphan02 ketphan02 requested a review from Opeyem1a April 3, 2022 16:10
@ketphan02 ketphan02 linked an issue Apr 3, 2022 that may be closed by this pull request
Comment thread src/components/App/DisplayPuzzleInstances/index.tsx Outdated
Comment thread src/components/App/DisplayPuzzleInstances/index.tsx Outdated
Comment thread src/components/App/DisplayPuzzleInstances/index.tsx Outdated
Comment thread src/components/App/PuzzleGenerate/index.tsx Outdated
Comment thread src/components/App/PuzzleGenerate/index.tsx Outdated
Comment thread src/styles/pages/admin.module.scss
@ketphan02 ketphan02 requested a review from Opeyem1a April 5, 2022 16:56
@Opeyem1a
Copy link
Copy Markdown
Contributor

Opeyem1a commented Apr 5, 2022

Yeah let's make sure QR codes are encoding the links to the submit-puzzle page

Copy link
Copy Markdown
Contributor

@Opeyem1a Opeyem1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about QR codes from the Trello card

@ketphan02 ketphan02 requested a review from Opeyem1a April 10, 2022 16:02
@ketphan02
Copy link
Copy Markdown
Collaborator Author

@Opeyem1a fixed!

Copy link
Copy Markdown
Contributor

@Opeyem1a Opeyem1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link for solve puzzle page in the QRGenerator should be generated with a util function and not hadcoded

@ketphan02 ketphan02 requested a review from Opeyem1a April 11, 2022 19:51
@Opeyem1a Opeyem1a merged commit f89df7e into main Apr 11, 2022
@Opeyem1a Opeyem1a deleted the admin-page-styling branch April 11, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add header for admin page Fix admin page styling

2 participants