Mesh Convention Tools for Upstreaming to pyvale - #21
Open
ScepticalRabbit wants to merge 39 commits into
Open
Conversation
…mplemented them in the codebase
# Conflicts: # build.zig
…debug across OS thread scheduling
…streaming to pyvale render api
16 tasks
Collaborator
Author
|
@james-panayis and @meganasampson I have raised a PR in pyvale that is now dependent on this being merged. If there are no review comments by Friday this week I am going to merge anyway and create a new Riley release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mesh Convention Module
Why: Riley expects that an input mesh will follow a certain convention to maintain correctness of shape function interpolation as well as visbility tests like back face culling.
What: Added a python module for checking and enforcing Riley's expected mesh convention before using meshes for rendering including:
Other/Misc Additions & Improvements
Additions to Riley's core zig rasteriser:
Global sub-pixel image buffers: Added global sub-pixel and global sub-pixel stripe buffer related to #17 . Sub-pixel buffer modes are verified against tile local renders in the min and psf test suites for correctness but the code itself is janky and needs an in-depth review for performance, consistency and redundancy against the rest of the codebase.
NOTE: For now sub-pixel buffers should be treated as an experimental feature under developement.