chore(pumpkin-core): Avoid unnecessary allocations - #573
Merged
Merged
Conversation
ImkoMarijnissen
changed the title
EmirDe
approved these changes
Sep 17, 2026
EmirDe
left a comment
EmirDe
left a comment
Contributor
There was a problem hiding this comment.
Nice catch. I made a small change, now the temp_nogood is cleared at the start of the function call, rather than before every use. If you do not like the change, then revert it.
Another unrelated thing I noticed "is_extended_unit_propagation": I found the name a bit odd. Unit propagation comes from unit clauses, and now we are saying "extended unit nogood". It could work but not sure if ideal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimisations to avoid reallocations