Skip to content

chore(pumpkin-conflict-resolvers): Avoid unnecessarily retrieving PredicateId twice #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImkoMarijnissen merged 2 commits into from
Sep 17, 2026
Merged

chore(pumpkin-conflict-resolvers): Avoid unnecessarily retrieving PredicateId twice #574

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73c439c
chore: Avoid unnecessarily querying twice
ImkoMarijnissen Sep 17, 2026
9e70a4a
chore: remove comment
ImkoMarijnissen Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pumpkin-crates/conflict-resolvers/src/resolvers/working_nogood.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,12 @@ impl WorkingNogood {
predicate_id_generator: &mut PredicateIdGenerator,
mode: AnalysisMode,
) {
let predicate_id = predicate_id_generator.get_id(predicate);

if self.is_redundant(
predicate,
context,
predicate_id_generator.get_id(predicate),
predicate_id,
predicate_id_generator,
mode,
) {
Expand All @@ -105,8 +107,6 @@ impl WorkingNogood {

// We first retrieve the value that the predicate will get in the heap
let heap_value = get_heap_value(predicate, context);
// And its corresponding predicate id
let predicate_id = predicate_id_generator.get_id(predicate);

// Next, we restore the key in the heap
self.to_process_heap.restore_key(predicate_id);
Expand Down
Loading