Repository navigation
Verifier: controller advisory note says 'it does not show who played' - #123
Merged
Merged
Conversation
…dence only; it does not show who played' (string only; no logic, checks, scores or receipt changes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display string only. In
verify/verify.js, theclaimstext that the input advisory returns, and that the verifier's controller panel shows, changes from 'advisory evidence only — not cryptographic proof of a human player' to 'advisory evidence only; it does not show who played'. Nothing reads it as a value. Logic, flags, scores, checks and receipts are unchanged.node verify/test.mjspasses.Not changed:
input_summary.human_labelinside the signed receipts (125430, 170123, 220105), and the match pages copy it. The viewer shows the receipt's own field, so I left it.qor_receipt/receipt.pycopy of this string is in the live referee's library, so I left it.