Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

deps: dedupe and lockbump ethers, ethereumjs, web3 - #6192

Merged
gnidan merged 4 commits into
ConsenSys-archive:developfrom
legobeat:deps-bump-eth-libs
Sep 11, 2023
Merged

gnidan merged 4 commits into
ConsenSys-archive:developfrom
legobeat:deps-bump-eth-libs

Conversation

@legobeat

@legobeat legobeat commented Sep 11, 2023 •

Copy link
Copy Markdown
Contributor

PR description

Dedupes and performs lockfile bumps of packages in the ethers, ethereumjs, and web3 families.

Note that this implies a major upgrade of transitive bn.js from v4 to v5.

Related

Testing instructions

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if documentation updates are required.

Breaking changes and new features

  • I have added any needed breaking-change and new-feature labels for the appropriate packages.

@legobeat
legobeat force-pushed the deps-bump-eth-libs branch 2 times, most recently from 6420df4 to 0206a10 Compare September 11, 2023 16:19
@legobeat
legobeat marked this pull request as ready for review September 11, 2023 21:14

@haltman-at haltman-at left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this without changing any package.jsons, huh? Wow! Well if the tests are passing, I guess it's OK!

(We've still got multiple versions of ethers despite this, right? I seem to recall certain packages were using distinct major versions...)

@legobeat

legobeat commented Sep 11, 2023 •

Copy link
Copy Markdown
Contributor Author

@haltman-at : Yup! This doesn't do any semver-violating changes so nothing changed there.

FWIW there is sill ethers@^4 used in contracts and interface-adapter while the rest of the usage looks to all be v5.

@legobeat

legobeat commented Sep 11, 2023 •

Copy link
Copy Markdown
Contributor Author

FYI just added on 4372ee3 which dedupes the remaining @ethersproject/^5 duplicates.

@haltman-at

haltman-at commented Sep 11, 2023 •

Copy link
Copy Markdown
Contributor

Yeah, I remember there being a reason why contract is still on v4, although I don't remember offhand what it is. OTOH interface-adapter I didn't know about, I wonder if there's a reason for that one?

@gnidan gnidan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants