EchoJsonRpcServiceTest: direct test of EchoJsonRpcService in Java#323
Merged
msgilligan merged 1 commit intomasterfrom Mar 15, 2026
Merged
EchoJsonRpcServiceTest: direct test of EchoJsonRpcService in Java#323msgilligan merged 1 commit intomasterfrom
msgilligan merged 1 commit intomasterfrom
Conversation
msgilligan
force-pushed
the
msgilligan/EchoJsonRpcServiceTest
branch
from
b415b3c to
c2fd5ca
Compare
liamgilligan
approved these changes
Mar 15, 2026
Contributor
liamgilligan
left a comment
liamgilligan
left a comment
There was a problem hiding this comment.
Looks good to me. Obviously, when #300 merges, these tests will need to be changed.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #318 enabled support for JUnit Jupiter Java tests in
consensusj-jsonrpc. This PR adds a first (WIP) Java test class.