Skip to content

chore: remove failing tests - #1815

Merged
ivokub merged 2 commits into
masterfrom
chore/tests
Aug 24, 2026
Merged

chore: remove failing tests#1815
ivokub merged 2 commits into
masterfrom
chore/tests

Conversation

@ivokub

@ivokub ivokub commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Description

GKR serialization test makes sense, but it creates an issue as every time we create a new release it seems to start failing. As such, imo it is not reliable. And it also doesn't make sense to commit 10MB test fixture every time we do a release. As the file is binary then it just wastes space.

I also removed a multicommit test for case when we call WithCommitment without any inputs. For Groth16 backend it made sense, as the commitments were randomized, but with PLONK the commitment is deterministic (it is KZG commitment of the variables committed to).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Note

Low Risk
Changes only remove test generation and tests; no production proving, commitment, or GKR runtime logic is modified.

Overview
Removes the GKR-Poseidon2 end-to-end serialization integration path: the test vector generator no longer compiles a BLS12-377 circuit or writes gkr_poseidon2.scs / .wtns under integration_test/, and the integration test that loaded those binaries and called Solve is deleted. The generator’s parallel task list is trimmed accordingly, and the goroutine loop now passes each task into the closure and panics on error inline (replacing assertNoError).

Also deletes TestNoCommitVariable in std/multicommit, which asserted that a circuit could succeed when WithCommitment ran without using the commitment—behavior that matched Groth16-style randomization but not PLONK’s deterministic KZG commitments.

Reviewed by Cursor Bugbot for commit ad2e9bf. Bugbot is set up for automated code reviews on this repo. Configure here.

ivokub added 2 commits August 24, 2026 17:54
Signed-off-by: Ivo Kubjas <ivo.kubjas@consensys.net>
@ivokub
ivokub merged commit fd5c244 into master Aug 24, 2026
16 checks passed
@ivokub
ivokub deleted the chore/tests branch August 24, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant