chore: remove failing tests - #1815
Merged
Merged
Conversation
Signed-off-by: Ivo Kubjas <ivo.kubjas@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GKR serialization test makes sense, but it creates an issue as every time we create a new release it seems to start failing. As such, imo it is not reliable. And it also doesn't make sense to commit 10MB test fixture every time we do a release. As the file is binary then it just wastes space.
I also removed a multicommit test for case when we call WithCommitment without any inputs. For Groth16 backend it made sense, as the commitments were randomized, but with PLONK the commitment is deterministic (it is KZG commitment of the variables committed to).
Type of change
Checklist:
golangci-lintdoes not output errors locallyNote
Low Risk
Changes only remove test generation and tests; no production proving, commitment, or GKR runtime logic is modified.
Overview
Removes the GKR-Poseidon2 end-to-end serialization integration path: the test vector generator no longer compiles a BLS12-377 circuit or writes
gkr_poseidon2.scs/.wtnsunderintegration_test/, and the integration test that loaded those binaries and calledSolveis deleted. The generator’s parallel task list is trimmed accordingly, and the goroutine loop now passes each task into the closure and panics on error inline (replacingassertNoError).Also deletes
TestNoCommitVariableinstd/multicommit, which asserted that a circuit could succeed whenWithCommitmentran without using the commitment—behavior that matched Groth16-style randomization but not PLONK’s deterministic KZG commitments.Reviewed by Cursor Bugbot for commit ad2e9bf. Bugbot is set up for automated code reviews on this repo. Configure here.