chore(ci): delete dead preview workflow, relax coverage and Slack requirements - #1040
Merged
Conversation
…uirements Three unrelated CI cleanups: - Delete `publish-preview.yml`. It invokes `yarn prepare-preview-builds`, `yarn publish-previews`, and `scripts/generate-preview-build-message.ts`, none of which exist in this repo, and its `PUBLISH_PREVIEW_NPM_TOKEN` is not configured. The workflow cannot have run successfully. - Mark `SLACK_WEBHOOK_URL` optional in `publish-release.yml`. The `slack-webhook-url` input of `MetaMask/action-npm-publish` is itself optional, and every Slack step in that action is guarded on it being non-empty, so requiring it here was stricter than the contract it feeds. - Stop failing the coverage report when no baseline exists, and derive the GitHub Pages URL from the workflow context instead of hardcoding it. A missing baseline now drops trend indicators instead of failing the job. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The preview-build workflow was the only consumer of these scripts, so with it gone all 31 of them are unreachable, as is the constraint that required them of every published package. Removing the script from `template-package` also stops new packages from inheriting it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Coverage Report
File CoverageNo changed files found. |
rekmarks
enabled auto-merge
September 2, 2026 17:32
sirtimid
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanups around the preview-build workflow, which turns out never to have been able to
run, plus two constraints that were stricter than the tooling underneath them.
Changes
Delete
publish-preview.yml. This is a feature used byMetaMask/corethat we never implemented. The workflow invokedyarn prepare-preview-builds,yarn publish-previews, andscripts/generate-preview-build-message.ts. None of theseexist, and
git logshows the latter two never did, so any@metamaskbot publish-previewcomment would have failed on the first step.
PUBLISH_PREVIEW_NPM_TOKENwas neverconfigured either.
Drop the orphaned
publish:previewscripts and their constraint. That workflow wasthe only consumer, so all 31 copies of the script are unreachable, as is the
yarn.config.cjsconstraint requiring one of every published package. Removing it fromtemplate-packagealso stops new packages from inheriting it.publish-release.yml:SLACK_WEBHOOK_URLis nowrequired: false. Theslack-webhook-urlinput ofMetaMask/action-npm-publishis itself optional, and allfour of its Slack steps are guarded on the value being non-empty. The
publish-npmjobin this same file already omits the input, so that path is already exercised.
coverage-report.yml: derive the Pages URL, and tolerate a missing baseline. The URLnow comes from
github.repository_ownerandgithub.repositoryinstead of beinghardcoded. A failed baseline fetch emits a warning and an empty compare path instead of
exit 1, so the report renders without trend indicators rather than painting the checkred.
Testing
yarn constraints,yarn lint:eslint, andyarn lint:dependenciespass, as doactionlint,shellcheck, andprettier --check. No source changed, so build and testare unaffected — though
constraintsand depcheck between them parse everypackage.jsontouched here.
The coverage change is the only one with logic worth exercising.
json-summary-compare-pathhas no default in the action's
action.ymland is read viacore.getInputbehind atruthiness check, so an empty string is identical to omitting the input. The
if curl ...; then ... else ... fiform is exempt fromerrexit, so a 404 takes theelsebranch rather than aborting the step — confirmed against a real 404 under
bash -e.coverage-reportis not in theall-jobs-completegate, so this changes only whether thatcheck reports green, not mergeability.
🤖 Generated with Claude Code
Note
Low Risk
Changes are limited to CI workflows and package scripts; release publish logic is unchanged except optional Slack secret validation.
Overview
This PR trims CI and monorepo constraints around preview publishing and tightens coverage reporting behavior.
Coverage reporting now builds the GitHub Pages baseline URL from
github.repository_ownerandgithub.repositoryinstead of a hardcoded host. If that fetch fails, the workflow logs a warning, leaves the compare path empty, and still posts the PR coverage report without trend deltas instead of failing the job.Release workflow treats
SLACK_WEBHOOK_URLas optional on the reusablepublish-releaseworkflow, matching optional Slack handling in the publish action.Preview publishing is removed end-to-end: the
publish-preview.ymlworkflow is deleted, every workspace loses thepublish:previewscript, andyarn.config.cjsno longer requires that script on published packages.Reviewed by Cursor Bugbot for commit acc8f04. Bugbot is set up for automated code reviews on this repo. Configure here.