Skip to content

chore(ci): delete dead preview workflow, relax coverage and Slack requirements - #1040

Merged
rekmarks merged 2 commits into
mainfrom
rekm/ci-tweaks
Sep 2, 2026
Merged

chore(ci): delete dead preview workflow, relax coverage and Slack requirements#1040
rekmarks merged 2 commits into
mainfrom
rekm/ci-tweaks

Conversation

@rekmarks

@rekmarks rekmarks commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Cleanups around the preview-build workflow, which turns out never to have been able to
run, plus two constraints that were stricter than the tooling underneath them.

Changes

  • Delete publish-preview.yml. This is a feature used by MetaMask/core that we never implemented. The workflow invoked yarn prepare-preview-builds,
    yarn publish-previews, and scripts/generate-preview-build-message.ts. None of these
    exist, and git log shows the latter two never did, so any @metamaskbot publish-preview
    comment would have failed on the first step. PUBLISH_PREVIEW_NPM_TOKEN was never
    configured either.

  • Drop the orphaned publish:preview scripts and their constraint. That workflow was
    the only consumer, so all 31 copies of the script are unreachable, as is the
    yarn.config.cjs constraint requiring one of every published package. Removing it from
    template-package also stops new packages from inheriting it.

  • publish-release.yml: SLACK_WEBHOOK_URL is now required: false. The
    slack-webhook-url input of MetaMask/action-npm-publish is itself optional, and all
    four of its Slack steps are guarded on the value being non-empty. The publish-npm job
    in this same file already omits the input, so that path is already exercised.

  • coverage-report.yml: derive the Pages URL, and tolerate a missing baseline. The URL
    now comes from github.repository_owner and github.repository instead of being
    hardcoded. A failed baseline fetch emits a warning and an empty compare path instead of
    exit 1, so the report renders without trend indicators rather than painting the check
    red.

Testing

yarn constraints, yarn lint:eslint, and yarn lint:dependencies pass, as do
actionlint, shellcheck, and prettier --check. No source changed, so build and test
are unaffected — though constraints and depcheck between them parse every package.json
touched here.

The coverage change is the only one with logic worth exercising. json-summary-compare-path
has no default in the action's action.yml and is read via core.getInput behind a
truthiness check, so an empty string is identical to omitting the input. The
if curl ...; then ... else ... fi form is exempt from errexit, so a 404 takes the else
branch rather than aborting the step — confirmed against a real 404 under bash -e.

coverage-report is not in the all-jobs-complete gate, so this changes only whether that
check reports green, not mergeability.

🤖 Generated with Claude Code


Note

Low Risk
Changes are limited to CI workflows and package scripts; release publish logic is unchanged except optional Slack secret validation.

Overview
This PR trims CI and monorepo constraints around preview publishing and tightens coverage reporting behavior.

Coverage reporting now builds the GitHub Pages baseline URL from github.repository_owner and github.repository instead of a hardcoded host. If that fetch fails, the workflow logs a warning, leaves the compare path empty, and still posts the PR coverage report without trend deltas instead of failing the job.

Release workflow treats SLACK_WEBHOOK_URL as optional on the reusable publish-release workflow, matching optional Slack handling in the publish action.

Preview publishing is removed end-to-end: the publish-preview.yml workflow is deleted, every workspace loses the publish:preview script, and yarn.config.cjs no longer requires that script on published packages.

Reviewed by Cursor Bugbot for commit acc8f04. Bugbot is set up for automated code reviews on this repo. Configure here.

…uirements

Three unrelated CI cleanups:

- Delete `publish-preview.yml`. It invokes `yarn prepare-preview-builds`,
  `yarn publish-previews`, and `scripts/generate-preview-build-message.ts`,
  none of which exist in this repo, and its `PUBLISH_PREVIEW_NPM_TOKEN` is
  not configured. The workflow cannot have run successfully.

- Mark `SLACK_WEBHOOK_URL` optional in `publish-release.yml`. The
  `slack-webhook-url` input of `MetaMask/action-npm-publish` is itself
  optional, and every Slack step in that action is guarded on it being
  non-empty, so requiring it here was stricter than the contract it feeds.

- Stop failing the coverage report when no baseline exists, and derive the
  GitHub Pages URL from the workflow context instead of hardcoding it.
  A missing baseline now drops trend indicators instead of failing the job.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@rekmarks
rekmarks requested a review from a team as a code owner September 2, 2026 16:32
@rekmarks rekmarks added the no-changelog Indicates that no changelog updates are required, and that related CI checks should be skipped. label Sep 2, 2026
The preview-build workflow was the only consumer of these scripts, so with it
gone all 31 of them are unreachable, as is the constraint that required them of
every published package. Removing the script from `template-package` also stops
new packages from inheriting it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 73.05%
🟰 ±0%
9790 / 13401
🔵 Statements 72.9%
🟰 ±0%
9954 / 13653
🔵 Functions 73.6%
🟰 ±0%
2301 / 3126
🔵 Branches 67.27%
🟰 ±0%
4023 / 5980
File CoverageNo changed files found.
Generated in workflow #4710 for commit acc8f04 by the Vitest Coverage Report Action

@rekmarks
rekmarks enabled auto-merge September 2, 2026 17:32
@rekmarks
rekmarks added this pull request to the merge queue Sep 2, 2026
Merged via the queue into main with commit bcf290e Sep 2, 2026
34 checks passed
@rekmarks
rekmarks deleted the rekm/ci-tweaks branch September 2, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that no changelog updates are required, and that related CI checks should be skipped.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants