Stop emitting duplicate head events for gloas - #11127
Open
Matilda-Clerke wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit eb8ad51. Configure here.
| previousDutyDependentRoot, | ||
| currentDutyDependentRoot); | ||
| notifySubscribersOfEvent(EventType.head, headEvent); | ||
| } |
There was a problem hiding this comment.
Head stop breaks remote validators
High Severity
Gating head behind pre-GLOAS stops events that Teku's remote validator still exclusively consumes. That client only subscribes to head and uses it for onHeadUpdate duty revalidation and early attestation triggers, so after GLOAS those validators receive no head notifications and duties may not recalculate on reorgs.
Reviewed by Cursor Bugbot for commit eb8ad51. Configure here.
rolfyone
reviewed
Aug 18, 2026
rolfyone
reviewed
Aug 18, 2026
rolfyone
reviewed
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Description
Stop emitting head v1 events post-GLOAS
Fixed Issue(s)
#10976
Changelog
Note
Medium Risk
Changes observable REST event behavior for integrations subscribed to
headon GLOAS networks; mitigated becausehead_v2continues to fire for the same updates.Overview
On GLOAS and later milestones, beacon REST SSE subscribers no longer receive duplicate
head(v1) events when the chain head updates;head_v2remains emitted for every head update as before.EventSubscriptionManager.chainHeadUpdatednow only callsnotifySubscribersOfEvent(EventType.head, …)whenspec.atSlot(slot).getMilestone()is strictly beforeSpecMilestone.GLOAS. Pre-GLOAS behavior is unchanged.Tests were updated for a minimal Gloas spec to assert
event: headis absent whilehead_v2is still delivered when clients subscribe to both topics. The changelog records this under bug fixes.Reviewed by Cursor Bugbot for commit eb8ad51. Bugbot is set up for automated code reviews on this repo. Configure here.