Skip to content

Clean-up empty overrides (ValidatorTimingChannel) - #11230

Open
StefanBratanov wants to merge 1 commit into
Consensys-Incorporated:masterfrom
StefanBratanov:clean_up_empty_overrides
Open

Clean-up empty overrides (ValidatorTimingChannel)#11230
StefanBratanov wants to merge 1 commit into
Consensys-Incorporated:masterfrom
StefanBratanov:clean_up_empty_overrides

Conversation

@StefanBratanov

Copy link
Copy Markdown
Contributor

PR Description

We do empty overrides for ValidatorTimingChannel which is just empty code, so cleaning it up

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@zilm13 zilm13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

I'd not that

AttestationDutySchedulerTest covers both sides of the guard in AbstractDutyScheduler.onAttestationAggregationDue
(validator/client/src/main/java/tech/pegasys/teku/validator/client/AbstractDutyScheduler.java:171):

  • shouldNotProcessAggregationIfCurrentEpochIsTooFarBeforeSlotEpoch (AttestationDutySchedulerTest.java:316) — current epoch 0, slot in epoch lookAhead+1 → verify(scheduledDuties,
    never()).performAggregationDuty(slot).
  • shouldProcessAggregationIfCurrentEpochIsAtBoundaryOfLookaheadEpoch (:338) — last slot still within the window → duty performed. So the boundary is pinned on both sides.
  • shouldNotProcessAggregationIfEpochIsUnknown (:302) — the currentEpoch.isEmpty() branch of isSlotTooFarAhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants