Don't mark block as invalid when exception is unknown - #11231
Open
zilm13 wants to merge 1 commit into
Open
Conversation
tbenr
reviewed
Sep 4, 2026
| } | ||
| return true; | ||
| private static boolean internalErrorToBeConsiderAsInvalidBlock(final Throwable internalError) { | ||
| // hasCause also checks the exception itself |
Contributor
There was a problem hiding this comment.
what about the original internalError instanceof RejectedExecutionException || ?
Contributor
Author
There was a problem hiding this comment.
it's opposite originally
private boolean internalErrorToBeConsiderAsInvalidBlock(final Throwable internalError) {
if (internalError instanceof RejectedExecutionException
|| ExceptionUtil.hasCause(internalError, RejectedExecutionException.class)) {
return false;
}
i guess because we don't want to stuck forever on EL malfunctioning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Replacement of broad rule which could mark block invalid incorrectly
Fixed Issue(s)
Fixes #11225
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog