Skip to content

chore: pin GitHub Actions to commit SHAs - #13

Closed
BGos87 wants to merge 1 commit into
mainfrom
chore/pin-github-actions-20260513
Closed

chore: pin GitHub Actions to commit SHAs#13
BGos87 wants to merge 1 commit into
mainfrom
chore/pin-github-actions-20260513

Conversation

@BGos87

@BGos87 BGos87 commented May 13, 2026

Copy link
Copy Markdown

Summary

Pin every uses: ref in .github/workflows/ (and any composite action
files) to a full 40-character commit SHA, with the original tag
preserved as a # vX comment.

Why

Tags and branches are mutable, so a compromised action can replace what
runs in our pipelines without changing the tag we reference. Pinning to
a SHA closes that supply-chain vector. See GitHub's hardening guide:
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions.

Deadline

TechOps is enforcing SHA-pinned GitHub Actions across the org by
June 8, 2026.
Merging this PR brings the repo into compliance ahead
of the cut-over; after that date workflows that still reference
mutable tags or branches will be blocked from running.

How

Generated mechanically with pinact run.
No version bumps were applied (strict pin); follow-up upgrades can come
from Renovate or a separate pinact run -u PR.

Test plan

  • CI green on this branch

Note

Low Risk
Low risk workflow-only change that pins a third-party GitHub Action to an immutable SHA; no behavior changes expected beyond supply-chain hardening.

Overview
Pins gaurav-nelson/github-action-markdown-link-check from the mutable @v1 ref to a specific commit SHA in both the weekly (check-links-nightly.yml) and PR (check-links.yml) link-check workflows, preserving the original version as a # v1 comment.

Reviewed by Cursor Bugbot for commit b302d94. Bugbot is set up for automated code reviews on this repo. Configure here.

Pin every `uses:` ref in .github/workflows and composite actions to a
full 40-character commit SHA, with the original tag preserved as a
comment, e.g.

    uses: actions/checkout@11bd719 # v4

Tags and branches are mutable; commit SHAs are not. Pinning to a SHA
closes a supply-chain vector where a compromised action could replace
what runs in CI without changing the tag we reference.

Generated mechanically with `pinact run`
(https://github.com/suzuki-shunsuke/pinact). No version bumps were
applied (strict pin).

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b302d94. Configure here.

steps:
- uses: actions/checkout@master
- uses: gaurav-nelson/github-action-markdown-link-check@v1
- uses: gaurav-nelson/github-action-markdown-link-check@5c5dfc0ac2e225883c0e5f03a85311ec2830d368 # v1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout@master left unpinned in both workflows

High Severity

This PR's stated goal is to "Pin every uses: ref" to a commit SHA, but actions/checkout@master remains unpinned in both workflow files. Referencing @master is a mutable branch ref — even riskier than the mutable tag refs this PR fixes — and leaves the same supply-chain attack vector open that the PR claims to close. The TechOps compliance deadline will not be met for these workflows.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b302d94. Configure here.

@BGos87 BGos87 closed this May 13, 2026
@BGos87
BGos87 deleted the chore/pin-github-actions-20260513 branch May 13, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant