Other sync improvements - #11162
Merged
Merged
Conversation
2. Cancel should cancel active batch import 3. Add debug logging
zilm13
marked this pull request as draft
August 24, 2026 21:14
zilm13
marked this pull request as ready for review
August 26, 2026 10:05
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 2f15df0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Description
It's made over #11158, so it should be merged first
includes:
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes sync import lifecycle, DAS tracker eviction, and availability timeouts鈥攁reas that affect catch-up sync and block import under Fulu, but behavior is guarded with targeted tests.
Overview
This PR hardens multi-peer batch sync and Fulu data-column availability so large catch-up imports don鈥檛 stall or fail prematurely.
Batch import:
BatchSyncnow useshandleAsyncon batch import futures and routes exceptional completion throughonImportFailed, which logs, releases importing state, and treats the outcome likeIMPORT_FAILEDso sync can retry instead of hanging. Import pause warnings include batch slot ranges; chain-switch while an import is in flight is covered when the delayed import fails exceptionally.DAS during sync:
DataColumnSidecarAvailabilityCheckerapplies a 5脳 slot-duration timeout for blocks more than one epoch behind the current slot (batch sync can pull ~125 slots at once).DasSamplerBasicImplonly soft-evicts sampling trackers when eviction is safe (failed sampling or sampling complete and the block is already satisfied in chain/store), keeping trackers needed for pending imports.Sidecar retrieval:
SimpleSidecarRetrieverskips stale matches, cancels in-flight RPC when gossip satisfies the request, and does not penalize peer scores for client-side cancellations.SyncConfigcomments clarify the recently-sampled-blocks soft limit vs the sampler hard cap.Reviewed by Cursor Bugbot for commit b127a87. Bugbot is set up for automated code reviews on this repo. Configure here.