refactor gossip test executor - #11175
Merged
gfukushima merged 2 commits intoAug 27, 2026
Merged
Conversation
…rvements to gossip validator help Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor some of the setup form the gossip test executors and fixed some nits from PR #11168
PR Description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Mostly test refactoring; the
isPossibleDependentRootchange alters production gossip validation for proposer preferences and should be verified against reference tests.Overview
Introduces
GossipTestContextto centralize gossip reference-test setup (in-memory store, anchor, fork choice, execution-layer stub) and shared helpers:assertValidationResultfor valid/reject/ignore expectations and a singleFinalizedCheckpointYAML type. Block-, attestation-, aggregate-, blob-, sync-committee, ePBS, and related executors now callGossipTestContext.createand drop duplicated boilerplate and per-fileFinalizedCheckpointclasses.Separately,
GossipValidationHelper.isPossibleDependentRootnow returns false when the candidate block’s slot is already at or after the epoch start slot, matching specis_valid_dependent_root(relevant to proposer-preferences gossip validation).Reviewed by Cursor Bugbot for commit d5ec68d. Bugbot is set up for automated code reviews on this repo. Configure here.