Skip to content

refactor gossip test executor - #11175

Merged
gfukushima merged 2 commits into
Consensys:masterfrom
gfukushima:refactor-gossip-test-executor
Aug 27, 2026
Merged

refactor gossip test executor#11175
gfukushima merged 2 commits into
Consensys:masterfrom
gfukushima:refactor-gossip-test-executor

Conversation

@gfukushima

@gfukushima gfukushima commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

refactor some of the setup form the gossip test executors and fixed some nits from PR #11168

PR Description

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Medium Risk
Mostly test refactoring; the isPossibleDependentRoot change alters production gossip validation for proposer preferences and should be verified against reference tests.

Overview
Introduces GossipTestContext to centralize gossip reference-test setup (in-memory store, anchor, fork choice, execution-layer stub) and shared helpers: assertValidationResult for valid/reject/ignore expectations and a single FinalizedCheckpoint YAML type. Block-, attestation-, aggregate-, blob-, sync-committee, ePBS, and related executors now call GossipTestContext.create and drop duplicated boilerplate and per-file FinalizedCheckpoint classes.

Separately, GossipValidationHelper.isPossibleDependentRoot now returns false when the candidate block’s slot is already at or after the epoch start slot, matching spec is_valid_dependent_root (relevant to proposer-preferences gossip validation).

Reviewed by Cursor Bugbot for commit d5ec68d. Bugbot is set up for automated code reviews on this repo. Configure here.

…rvements to gossip validator help

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

@rolfyone rolfyone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfukushima
gfukushima enabled auto-merge (squash) August 27, 2026 00:16
@gfukushima
gfukushima merged commit f5e1ba7 into Consensys:master Aug 27, 2026
84 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants