Skip to content

Upgrade gradle + windows commands in build.gradle - #11176

Open
StefanBratanov wants to merge 2 commits into
Consensys:masterfrom
StefanBratanov:upgrade_gradle
Open

Upgrade gradle + windows commands in build.gradle#11176
StefanBratanov wants to merge 2 commits into
Consensys:masterfrom
StefanBratanov:upgrade_gradle

Conversation

@StefanBratanov

@StefanBratanov StefanBratanov commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

PR Description

Upgrade to gradle 9.7.1 + reviving gradlew.bat

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Low Risk
Build-tooling-only wrapper and script changes; the Gradle minor bump could surface plugin or build behavior differences in CI.

Overview
This PR bumps the Gradle wrapper from 9.5.1 to 9.7.1, updating gradle/wrapper/gradle-wrapper.properties (distribution URL and checksum) and refreshing the Unix gradlew script with the matching generated template comments.

It also adds gradlew.bat, so Windows environments can invoke the wrapper via the standard batch entry point instead of relying on Unix-only ./gradlew.

Reviewed by Cursor Bugbot for commit d534b87. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit f446b43. Configure here.

Comment thread build.gradle Outdated
@lucassaldanha

Copy link
Copy Markdown
Member

My biggest concern with this change is that we wouldn't be exercising the windows "path" frequently, what could lead to them being broken for ages until we figure it out.

The alternative to that would be running them again on CI regularly, but we already know that we don't want that.

So I am not sure what is the best way forward to maintain them.

@zilm13

zilm13 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

My biggest concern with this change is that we wouldn't be exercising the windows "path" frequently, what could lead to them being broken for ages until we figure it out

If we get 0 feedback in this case, it means noone uses it, so it's not a big deal

@StefanBratanov

StefanBratanov commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

I am thinking of giving up on this one and just keeping the change on my local, but can we at keep gradlew.bat. It doesn't hurt being there. I modified the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants