1/2 sidecars storage on supernodes: RPC logging + more RPC tests - #11183
Open
zilm13 wants to merge 1 commit into
Open
1/2 sidecars storage on supernodes: RPC logging + more RPC tests#11183zilm13 wants to merge 1 commit into
zilm13 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Trying to split #10132 into a smaller parts.
This one includes
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Low Risk
Observability-only handler changes plus unit tests; RPC behavior is unchanged aside from new debug log lines.
Overview
Adds DEBUG logging to the DataColumnSidecarsByRange and DataColumnSidecarsByRoot inbound handlers when supernode archive reconstruction runs: one message when the backing block is missing (reconstruction skipped), and one when a reconstructed sidecar is actually served.
Tests cover the happy path (stored + pruned columns served via reconstruction for by-range; four by-root reconstructions with log capture) and the guard path where getBlockAtSlotExact / getBlockByBlockRoot returns empty so reconstructDataColumnSidecar is never invoked.
Reviewed by Cursor Bugbot for commit 6aca53b. Bugbot is set up for automated code reviews on this repo. Configure here.