feat: schema mapping, delete fix, and gap closures CEP-6#81
Open
harsh04044 wants to merge 1 commit into
Open
Conversation
…s, and gap closures
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR closing CEP-6 implementation #76.
What's in this PR:
Schema-to-kind mapping table - replaced the field-presence if-else chain in handle_announcement_response() with a typed mapping table. Each entry validates field types (arrays must be arrays, strings must be strings), matching TS SDK's safeParse semantics. Rejects malformed payloads like {"tools": null}.
Delete fix - delete_announcements() now fetches existing events per kind via fetch_events() and publishes kind 5 with ["e", event_id] tags for each found event. Added fetch_events() to RelayPoolTrait and MockRelayPool.
Integration tests - roundtrip publish→discover for all 5 kinds, delete tag format verification, schema rejection tests.
Gap closures - 5 tests added for CEP-6 parity with TS SDK:
Also fixed a wrong integration test that expected the old ["k", kind] deletion behavior.