Skip to content

🧪 Add tests for has_current_head_approval in pr_review_merge_scheduler.py#70

Merged
seonghobae merged 3 commits into
developfrom
jules-add-tests-has-current-head-approval-328593231527354000
Jun 16, 2026
Merged

🧪 Add tests for has_current_head_approval in pr_review_merge_scheduler.py#70
seonghobae merged 3 commits into
developfrom
jules-add-tests-has-current-head-approval-328593231527354000

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

🎯 What: The has_current_head_approval function in scripts/ci/pr_review_merge_scheduler.py lacked unit test coverage, making it susceptible to regressions if refactored.
📊 Coverage: The new tests cover:

  • Returns True when an "APPROVED" review matches the current head commit, authored by the expected agent.
  • Returns True when reviewDecision is directly set to "APPROVED" by GitHub.
  • Returns False when review state is "CHANGES_REQUESTED".
  • Returns False when an "APPROVED" review exists, but for an older commit.
  • Returns False when an "APPROVED" review is authored by a non-agent user.
  • Returns False when handling an empty or partially populated PR dictionary.
    Result: Enhanced test suite reliability by ensuring this crucial logic accurately handles various PR state payloads from the GitHub API.

PR created automatically by Jules for task 328593231527354000 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Copilot, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 34 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 92a9b281-edf3-4ea3-a9fc-4f0fd03090ed

📥 Commits

Reviewing files that changed from the base of the PR and between f1b81c3 and 949c363.

📒 Files selected for processing (1)
  • tests/test_pr_review_merge_scheduler.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jules-add-tests-has-current-head-approval-328593231527354000
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch jules-add-tests-has-current-head-approval-328593231527354000

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 949c363f0b00d94aff00fa719b34bef04ffad49c
  • Workflow run: 27599887639
  • Workflow attempt: 2
  • Gate result: APPROVE (exit 0)

But note: the instructions say "Do not include analysis, planning, tool-call narration, placeholders, or prose before the sentinel."

So we must output exactly:

However, the first line is already provided? Actually, the evidence says: "First line exactly: ..." and then we are to output the control block.

So we output:

But note: the evidence says "Then exactly one control block", meaning we output the first line and then the control block.

However, the first line is provided in the evidence? Actually, the evidence says: "First line exactly: ..." and then the control block.

We are to output the first line exactly as given, then the control block.

But wait: the evidence says: "Return only the review body." and the review body must start with that first line.

So we write:

We are not output anything else.

Let's format the JSON:

{
"head_sha": "949c363f0b00d94aff00fa719b34bef04ffad49c",
"run_id": "27599887639",
"run_attempt": "2",
"result": "APPROVE",
"reason": "Tests are well-structured and cover multiple scenarios",
"summary": "The PR adds 5 new tests for the has_current_head_approval function. The tests cover true conditions from review state and decision, false conditions for changes requested, wrong commit, wrong author, and missing keys. The tests are clear and cover the intended behavior.",
"findings": []
}

But note: the head_sha in the evidence is 949c363f0b00d94aff00fa719b34bef04ffad49c (exactly as in the evidence).

We are to use that.

We are done.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCode Agent review evidence was missing or invalid.

  • Reason: Approval gate result was NO_CONCLUSION.
  • Head SHA: 4a327b5363f089d79aab90df52685ee2e5774450
  • Workflow run: 27595667562
  • Workflow attempt: 1

@seonghobae

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCode Agent approved this PR.

The PR adds 5 new tests for the has_current_head_approval function. The tests cover true conditions from review state and decision, false conditions for changes requested, wrong commit, wrong author, and missing keys. The tests are clear and cover the intended behavior.

  • Result: APPROVE
  • Reason: Tests are well-structured and cover multiple scenarios
  • Head SHA: 949c363f0b00d94aff00fa719b34bef04ffad49c
  • Workflow run: 27599887639
  • Workflow attempt: 2

@seonghobae seonghobae merged commit e36a7c8 into develop Jun 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants