🛡️ Sentinel: [CRITICAL] Fix hardcoded admin credentials and CodeQL timing vulnerability

[seonghobae]

🚨 Severity: CRITICAL
💡 Vulnerability: Administrative credentials were hardcoded directly in the source code (admin-auth.ts). Additionally, createHmac was used to hash user-provided passwords for a timing-safe equality check, triggering a CodeQL static analysis alert for insecure password hashing on taint-tracked inputs.
🎯 Impact: An attacker who views the source code could immediately gain full administrative access using the hardcoded credentials. The CodeQL alert indicates poor cryptographic practices that can fail in static analysis systems.
🔧 Fix: Removed hardcoded strings and migrated ADMIN_USERNAME and ADMIN_PASSWORD to required environment variables validated strictly using Zod (.trim().min(32) for the password). Refactored safeEqual to use Buffer.from() and crypto.timingSafeEqual() with a dummy length check instead of createHmac to properly handle timing-side channels and pass CodeQL constraints. Updated .env.example and CI workflow files respectively.
✅ Verification: Ensure the .env file correctly applies variables during runtime without crashing validation, verify tests/builds successfully execute, and inspect .jules/sentinel.md for learning documentation.

---

PR created automatically by Jules for task 7577691253004960911 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 27 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 54d05090-9070-4cf1-833a-6ad5766d32ce

📥 Commits

Reviewing files that changed from the base of the PR and between 6d0144c and 3bec208.

📒 Files selected for processing (5)

• .github/workflows/ci.yml
• .jules/sentinel.md
• packages/web/.env.example
• packages/web/src/lib/server/admin-auth.ts
• packages/web/src/lib/server/env.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-hardcoded-admin-credentials-7577691253004960911

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch sentinel-fix-hardcoded-admin-credentials-7577691253004960911

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[seonghobae]

이 PR은 PR #7 (upstream PR vibemafiaclub#19)에 의해 대체되었습니다. PR #7에서 동일한 자격증명 환경변수화가 이미 반영되었으며, 리뷰어의 피드백에 따라 HMAC 기반 safeEqual 방식을 유지하고 있습니다. 닫겠습니다.

[google-labs-jules]

이 PR은 PR #7 (upstream PR vibemafiaclub#19)에 의해 대체되었습니다. PR #7에서 동일한 자격증명 환경변수화가 이미 반영되었으며, 리뷰어의 피드백에 따라 HMAC 기반 safeEqual 방식을 유지하고 있습니다. 닫겠습니다.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.