🛡️ Sentinel: [CRITICAL] Fix hardcoded admin password

[seonghobae]

🚨 Severity: CRITICAL
💡 Vulnerability: Hardcoded admin password secret exposed in source code. CodeQL also flagged the use of createHmac('sha256') applied to fields tracked from "password" strings as an insecure hash.
🎯 Impact: Attackers reading the source code could authenticate as the admin. The hashing issue flagged by CodeQL could allow timing attacks if left unchecked by simply suppressing it.
🔧 Fix: Extracted ADMIN_PASSWORD to environment variables and updated EnvSchema to validate it (z.string().trim().min(8)). Updated .env.example and ci.yml placeholders. Mitigated the CodeQL timing-safe equality issue by converting strings to Buffers, validating lengths with a dummy check to prevent timing leaks, and using direct crypto.timingSafeEqual instead of createHmac. Documented the process in .jules/sentinel.md.
✅ Verification: Ran pnpm lint, pnpm build, and tests for @argos/web successfully. Code review approved the constant-time buffer-comparison method.

---

PR created automatically by Jules for task 3705858935203681574 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 16 minutes and 5 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca8f687b-cd7f-4abb-aa9f-16b6cf4e6f8a

📥 Commits

Reviewing files that changed from the base of the PR and between 6d0144c and 81e9ff4.

📒 Files selected for processing (5)

• .github/workflows/ci.yml
• .jules/sentinel.md
• packages/web/.env.example
• packages/web/src/lib/server/admin-auth.ts
• packages/web/src/lib/server/env.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-hardcoded-secret-3705858935203681574

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch sentinel-fix-hardcoded-secret-3705858935203681574

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[seonghobae]

이 PR은 PR #7 (upstream PR vibemafiaclub#19)에 의해 대체되었습니다. PR #7에서 ADMIN_USERNAME과 ADMIN_PASSWORD 모두 환경변수화하는 더 완전한 구현이 적용되었습니다(이 PR은 ADMIN_PASSWORD만 처리). 닫겠습니다.

[google-labs-jules]

이 PR은 PR #7 (upstream PR vibemafiaclub#19)에 의해 대체되었습니다. PR #7에서 ADMIN_USERNAME과 ADMIN_PASSWORD 모두 환경변수화하는 더 완전한 구현이 적용되었습니다(이 PR은 ADMIN_PASSWORD만 처리). 닫겠습니다.

Understood. Acknowledging that this work is superseded by PR #7 and is now obsolete. I will stop work on this task.