Skip to content

๐ŸŽจ Palette: Improve accessibility of Overview Stats help toggle#34

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette/a11y-overview-stats-9235034310723989918
Closed

๐ŸŽจ Palette: Improve accessibility of Overview Stats help toggle#34
seonghobae wants to merge 1 commit into
mainfrom
palette/a11y-overview-stats-9235034310723989918

Conversation

@seonghobae

Copy link
Copy Markdown

๐Ÿ’ก What

Added semantic ARIA attributes and focus styling to the help toggle button in the OverviewStats component.

๐ŸŽฏ Why

Screen reader users previously received no indication of the button's toggle state (expanded vs collapsed) or the fact that it controls the help text section below it. Furthermore, redundant visual characters like the "โ–ธ" arrow and the explicit text "โ€” click to expand" were adding noise to screen reader announcements. Proper focus rings were also missing for keyboard users.

๐Ÿ“ธ Before/After

  • Added aria-expanded={expanded}.
  • Added aria-controls linked to a unique ID useId().
  • Added aria-hidden="true" to visual hints.
  • Added focus-visible:ring-2 class logic for keyboard outlines.

โ™ฟ Accessibility

This brings the simple disclosure interaction up to WCAG compliance and provides a much cleaner experience for those utilizing assistive technologies.


PR created automatically by Jules for task 9235034310723989918 started by @seonghobae

Adds appropriate ARIA attributes (`aria-expanded`, `aria-controls`, `aria-hidden`)
to the "What do these numbers mean?" disclosure button to properly communicate its
purpose and state to screen reader users. Also introduces a visible focus ring for
keyboard navigation usability.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

๐Ÿ“ Walkthrough

๊ฐœ์š”

OverviewStats ์ปดํฌ๋„ŒํŠธ์˜ ๋„์›€๋ง ํ† ๊ธ€ ๋ฒ„ํŠผ์— React useId ํ›…์„ ํ™œ์šฉํ•œ ์•ˆ์ •์ ์ธ ID ์ƒ์„ฑ, aria-expanded ๋ฐ aria-controls ์†์„ฑ, ๊ทธ๋ฆฌ๊ณ  aria-hidden ๋งˆํ‚น์„ ์ถ”๊ฐ€ํ•˜์—ฌ ์ ‘๊ทผ์„ฑ์„ ๊ฐœ์„ ํ•ฉ๋‹ˆ๋‹ค.

๋ณ€๊ฒฝ ์‚ฌํ•ญ

๋„์›€๋ง ํ† ๊ธ€ ์ ‘๊ทผ์„ฑ

๊ณ„์ธต / ํŒŒ์ผ ์š”์•ฝ
๋„์›€๋ง ID ๋ฐ ์ ‘๊ทผ์„ฑ ๊ตฌํ˜„
packages/web/src/components/dashboard/overview-stats.tsx
React useId๋ฅผ ์ž„ํฌํŠธํ•˜๊ณ , useId() ํ›…์œผ๋กœ ์•ˆ์ •์ ์ธ helpId๋ฅผ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค. ํ† ๊ธ€ ๋ฒ„ํŠผ์— aria-expanded์™€ aria-controls ์†์„ฑ์„ ์ถ”๊ฐ€ํ•˜๊ณ , ํ™•์žฅ ํŒจ๋„์— id={helpId}๋ฅผ ํ• ๋‹นํ•˜๋ฉฐ, ์žฅ์‹์šฉ chevron๊ณผ ํ…์ŠคํŠธ ์š”์†Œ์— aria-hidden์„ ์ ์šฉํ•ฉ๋‹ˆ๋‹ค.

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~10 ๋ถ„

๐Ÿฐ ๋ฒ„ํŠผ๊ณผ ํŒจ๋„์ด ์†์„ ๋งž์žก๊ณ ,
ARIA ์†์„ฑ์œผ๋กœ ์ถค์„ ์ถ”๋„ค์š”!
์Šคํฌ๋ฆฐ ๋ฆฌ๋”๋„ ํ•จ๊ป˜ ๋…ธ๋ž˜ ๋ถ€๋ฅด๊ณ ,
์ ‘๊ทผ์„ฑ ์™•๊ตญ์— ์ถ•๋ฐฐ๋ฅผ!
useId๋กœ ๋“ ๋“ ํžˆ ์•ˆ์ „ํ•˜๊ฒŒ~ ๐ŸŽ‰


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

โŒ Failed checks (1 error)

Check name Status Explanation Resolution
Docstring Coverage โŒ Error Docstring coverage is 0.00% which is insufficient. The required threshold is 100.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
โœ… Passed checks (4 passed)
Check name Status Explanation
Title check โœ… Passed ์ œ๋ชฉ์€ ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ(Overview Stats ํ—ฌํ”„ ํ† ๊ธ€์˜ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ )์„ ๋ช…ํ™•ํ•˜๊ฒŒ ์š”์•ฝํ•˜๋ฉฐ, ์ด๋ชจ์ง€๋ฅผ ์ œ์™ธํ•œ ํ…์ŠคํŠธ๋Š” ๊ตฌ์ฒด์ ์ด๊ณ  ์ดํ•ดํ•˜๊ธฐ ์‰ฝ๋‹ค.
Description check โœ… Passed ์„ค๋ช…์€ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์˜ ๋ชฉ์ (์ ‘๊ทผ์„ฑ ๊ฐœ์„ ), ๊ตฌ์ฒด์ ์ธ ์ˆ˜์ • ์‚ฌํ•ญ(aria ์†์„ฑ ์ถ”๊ฐ€, ํฌ์ปค์Šค ์Šคํƒ€์ผ๋ง), ๊ทธ๋ฆฌ๊ณ  WCAG ์ค€์ˆ˜์™€์˜ ์—ฐ๊ด€์„ฑ์„ ํฌํ•จํ•˜์—ฌ ๋ณ€๊ฒฝ ์‚ฌํ•ญ๊ณผ ๊ด€๋ จ์„ฑ์ด ๋†’๋‹ค.
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
โœจ Finishing Touches
๐Ÿ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/a11y-overview-stats-9235034310723989918
โœจ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch palette/a11y-overview-stats-9235034310723989918

Comment @coderabbitai help to get the list of available commands and usage tips.

@seonghobae

Copy link
Copy Markdown
Author

์ตœ์‹  upstream/main ๊ธฐ์ค€์œผ๋กœ ์ด PR์€ 80๊ฐœ ํŒŒ์ผ์˜ stale diff๋ฅผ ํฌํ•จํ•ฉ๋‹ˆ๋‹ค. ํŠนํžˆ .claude agent/skill ํŒŒ์ผ ์‚ญ์ œ์™€ ์˜ค๋ž˜๋œ ์›Œํฌํ”Œ๋กœ์šฐ/lockfile/env ๋ณ€๊ฒฝ์ด ์„ž์—ฌ ์žˆ์–ด ๊ทธ๋Œ€๋กœ ์œ ์ง€ํ•˜๊ฑฐ๋‚˜ upstream์— ์˜ฌ๋ฆฌ๋ฉด ์ด๋ฏธ ๋ฐ˜์˜๋œ ๋ณ€๊ฒฝ์„ ๋˜๋Œ๋ฆด ์œ„ํ—˜์ด ํฝ๋‹ˆ๋‹ค.

ํ˜„์žฌ ํ๋Š” upstream #30 โ†’ upstream #21 ์ˆœ์„œ๋กœ ์ •๋ฆฌ ์ค‘์ž…๋‹ˆ๋‹ค. ์ด PR์˜ ์•„์ด๋””์–ด๊ฐ€ ์—ฌ์ „ํžˆ ํ•„์š”ํ•˜๋ฉด ์ตœ์‹  upstream/main์—์„œ ๋‹จ์ผ ๋ชฉ์  ๋ธŒ๋žœ์น˜๋กœ ๊นจ๋—ํ•˜๊ฒŒ ๋‹ค์‹œ ์ถ”์ถœํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. stale PR๋กœ ๋‹ซ์Šต๋‹ˆ๋‹ค.

@seonghobae seonghobae closed this Jun 10, 2026
@google-labs-jules

Copy link
Copy Markdown

์ตœ์‹  upstream/main ๊ธฐ์ค€์œผ๋กœ ์ด PR์€ 80๊ฐœ ํŒŒ์ผ์˜ stale diff๋ฅผ ํฌํ•จํ•ฉ๋‹ˆ๋‹ค. ํŠนํžˆ .claude agent/skill ํŒŒ์ผ ์‚ญ์ œ์™€ ์˜ค๋ž˜๋œ ์›Œํฌํ”Œ๋กœ์šฐ/lockfile/env ๋ณ€๊ฒฝ์ด ์„ž์—ฌ ์žˆ์–ด ๊ทธ๋Œ€๋กœ ์œ ์ง€ํ•˜๊ฑฐ๋‚˜ upstream์— ์˜ฌ๋ฆฌ๋ฉด ์ด๋ฏธ ๋ฐ˜์˜๋œ ๋ณ€๊ฒฝ์„ ๋˜๋Œ๋ฆด ์œ„ํ—˜์ด ํฝ๋‹ˆ๋‹ค.

ํ˜„์žฌ ํ๋Š” upstream #30 โ†’ upstream #21 ์ˆœ์„œ๋กœ ์ •๋ฆฌ ์ค‘์ž…๋‹ˆ๋‹ค. ์ด PR์˜ ์•„์ด๋””์–ด๊ฐ€ ์—ฌ์ „ํžˆ ํ•„์š”ํ•˜๋ฉด ์ตœ์‹  upstream/main์—์„œ ๋‹จ์ผ ๋ชฉ์  ๋ธŒ๋žœ์น˜๋กœ ๊นจ๋—ํ•˜๊ฒŒ ๋‹ค์‹œ ์ถ”์ถœํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. stale PR๋กœ ๋‹ซ์Šต๋‹ˆ๋‹ค.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant