Skip to content

๐ŸŽจ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ : OverviewStats ํ† ๊ธ€ ๋ฒ„ํŠผ์— ARIA ๊ณต์‹œ ํŒจํ„ด ์ ์šฉ #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 3 commits into from
Closed

๐ŸŽจ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ : OverviewStats ํ† ๊ธ€ ๋ฒ„ํŠผ์— ARIA ๊ณต์‹œ ํŒจํ„ด ์ ์šฉ #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94a5a6d
feat(a11y): add aria-expanded and aria-controls to overview stats togโ€ฆ
seonghobae May 29, 2026
02a10ba
feat(a11y): add aria-expanded and aria-controls to overview stats togโ€ฆ
seonghobae May 30, 2026
d5f3970
fix(a11y): keep overview stats disclosure region in DOM
Codex May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-29 - [Expandable sections need ARIA attributes]

@coderabbitai coderabbitai Bot May 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โš ๏ธ Potential issue | ๐ŸŸก Minor | โšก Quick win

๋ฌธ์„œ ๋‚ ์งœ๋ฅผ ์‹ค์ œ ๋ณ€๊ฒฝ ์‹œ์ ์œผ๋กœ ๋งž์ถฐ ์ฃผ์„ธ์š”.

Line 1์˜ 2024-05-29๋Š” ์ด๋ฒˆ PR ์ƒ์„ฑ์ผ(2026-05-29)๊ณผ ๋งž์ง€ ์•Š์•„ ์ด๋ ฅ ์ถ”์ ์„ ํ˜ผ๋™์‹œํ‚ฌ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๋‚ ์งœ๋ฅผ ์‹ค์ œ ๋ฐ˜์˜์ผ๋กœ ์ˆ˜์ •ํ•˜๋Š” ๊ฒƒ์ด ์ข‹์Šต๋‹ˆ๋‹ค.

์ˆ˜์ • ์ œ์•ˆ 
-## 2024-05-29 - [Expandable sections need ARIA attributes]
+## 2026-05-29 - [Expandable sections need ARIA attributes]
๐Ÿ“ Committable suggestion

โ€ผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## 2024-05-29 - [Expandable sections need ARIA attributes]
## 2026-05-29 - [Expandable sections need ARIA attributes]
๐Ÿค– Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.Jules/palette.md at line 1, Update the document header date to match the
actual change date by replacing the header line starting with "## 2024-05-29 -
[Expandable sections need ARIA attributes]" to use the correct date (e.g., "##
2026-05-29 - [Expandable sections need ARIA attributes]") and scan the rest of
.Jules/palette.md for any other dated entries to update so the file's documented
date(s) reflect the real modification date.

**Learning:** Found an accordion/expandable pattern in `overview-stats.tsx` that lacked `aria-expanded` and `aria-controls`. The content block was also missing an `id` tying back to `aria-controls`.
**Action:** Applied standard disclosure pattern by providing `aria-expanded` to the toggler button, assigning an `id` to the toggled content, and adding `aria-controls="<id>"` to link them.
50 changes: 27 additions & 23 deletions packages/web/src/components/dashboard/overview-stats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,35 +86,39 @@ export function OverviewStats({
type="button"
onClick={() => setExpanded(v => !v)}
className="mt-4 flex items-center gap-2 text-xs text-muted-foreground hover:text-foreground transition-colors"
aria-expanded={expanded}
aria-controls="overview-stats-explanation"
>
<span className={cn('inline-block transition-transform', expanded && 'rotate-90')}>โ–ธ</span>
<span className="font-medium text-foreground">What do these numbers mean?</span>
<span>โ€” {expanded ? 'click to collapse' : 'click to expand'}</span>
</button>

{expanded && (
<div className="mt-3 text-xs text-muted-foreground space-y-2 leading-relaxed">
<p>
<span className="font-medium text-foreground">Sessions</span> โ€” ํŒ€์›๋“ค์ด ์‹œ์ž‘ํ•œ Claude Code ์„ธ์…˜ ์ˆ˜.
</p>
<p>
<span className="font-medium text-foreground">Turns</span> โ€” Human โ†’ Assistant ํ•œ ๋ฒˆ์˜ ์™•๋ณต(Stop ์ด๋ฒคํŠธ ๊ธฐ์ค€).
</p>
<p>
<span className="font-medium text-foreground">Input / Output</span> โ€” Claude์— ๋ณด๋‚ธ ํ† ํฐ๊ณผ Claude๊ฐ€ ์‘๋‹ต์œผ๋กœ ์“ด ํ† ํฐ์˜ ํ•ฉ๊ณ„.
</p>
<p>
<span className="font-medium text-foreground">Cache Create</span> โ€” ์žฌ์‚ฌ์šฉ์„ ์œ„ํ•ด ์ €์žฅ๋œ ํ† ํฐ(์˜ˆ: CLAUDE.md).
ํ•œ ๋ฒˆ ์ง€๋ถˆํ•˜๋ฉด ์ดํ›„ ์ฝ๊ธฐ๋Š” ํ›จ์”ฌ ์ €๋ ดํ•ด์ง‘๋‹ˆ๋‹ค.
</p>
<p>
<span className="font-medium text-foreground">Cache Read</span> โ€” ์บ์‹œ์—์„œ ์žฌ์‚ฌ์šฉ๋œ ํ† ํฐ. ์ผ๋ฐ˜ input ๋Œ€๋น„ ์•ฝ ~10ร— ์‹ธ๋ฏ€๋กœ ์ด ์ˆซ์ž๊ฐ€ ๋†’์€ ๊ฑด ์ข‹์€ ์‹ ํ˜ธ์ž…๋‹ˆ๋‹ค.
</p>
<p>
<span className="font-medium text-foreground">Est. Cost</span> โ€” ๋ชจ๋ธ๋ณ„ ๊ณต์‹ ๋‹จ๊ฐ€๋กœ ๊ณ„์‚ฐํ•œ ์ถ”์ • ์ฒญ๊ตฌ์•ก (USD).
</p>
</div>
)}
<div
id="overview-stats-explanation"
hidden={!expanded}
className="mt-3 text-xs text-muted-foreground space-y-2 leading-relaxed"
>
<p>
<span className="font-medium text-foreground">Sessions</span> โ€” ํŒ€์›๋“ค์ด ์‹œ์ž‘ํ•œ Claude Code ์„ธ์…˜ ์ˆ˜.
</p>
<p>
<span className="font-medium text-foreground">Turns</span> โ€” Human โ†’ Assistant ํ•œ ๋ฒˆ์˜ ์™•๋ณต(Stop ์ด๋ฒคํŠธ ๊ธฐ์ค€).
</p>
<p>
<span className="font-medium text-foreground">Input / Output</span> โ€” Claude์— ๋ณด๋‚ธ ํ† ํฐ๊ณผ Claude๊ฐ€ ์‘๋‹ต์œผ๋กœ ์“ด ํ† ํฐ์˜ ํ•ฉ๊ณ„.
</p>
<p>
<span className="font-medium text-foreground">Cache Create</span> โ€” ์žฌ์‚ฌ์šฉ์„ ์œ„ํ•ด ์ €์žฅ๋œ ํ† ํฐ(์˜ˆ: CLAUDE.md).
ํ•œ ๋ฒˆ ์ง€๋ถˆํ•˜๋ฉด ์ดํ›„ ์ฝ๊ธฐ๋Š” ํ›จ์”ฌ ์ €๋ ดํ•ด์ง‘๋‹ˆ๋‹ค.
</p>
<p>
<span className="font-medium text-foreground">Cache Read</span> โ€” ์บ์‹œ์—์„œ ์žฌ์‚ฌ์šฉ๋œ ํ† ํฐ. ์ผ๋ฐ˜ input ๋Œ€๋น„ ์•ฝ ~10ร— ์‹ธ๋ฏ€๋กœ ์ด ์ˆซ์ž๊ฐ€ ๋†’์€ ๊ฑด ์ข‹์€ ์‹ ํ˜ธ์ž…๋‹ˆ๋‹ค.
</p>
<p>
<span className="font-medium text-foreground">Est. Cost</span> โ€” ๋ชจ๋ธ๋ณ„ ๊ณต์‹ ๋‹จ๊ฐ€๋กœ ๊ณ„์‚ฐํ•œ ์ถ”์ • ์ฒญ๊ตฌ์•ก (USD).
</p>
</div>
</div>
)
}