๐จ Palette: [Accessibility] Improve collapsible section in Overview Stats#71
๐จ Palette: [Accessibility] Improve collapsible section in Overview Stats#71seonghobae wants to merge 1 commit into
Conversation
Added `aria-expanded` and `aria-controls` to the toggle button, `id` to the content container, and `aria-hidden` to purely decorative elements to improve screen reader experience.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. ๐ โน๏ธ Recent review infoโ๏ธ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ๐ Files selected for processing (2)
๐ WalkthroughSummary by CodeRabbit๋ฆด๋ฆฌ์ค ๋ ธํธ
WalkthroughOverviewStats ์ปดํฌ๋ํธ์ ํ ๊ธ ๋ฒํผ์ ARIA ์ ๊ทผ์ฑ ์์ฑ์ ์ถ๊ฐํ์ต๋๋ค. ๋ฒํผ์ ChangesToggle ๋ฒํผ ARIA ์ ๊ทผ์ฑ ๊ฐ์
์์ ์ฝ๋ ๋ฆฌ๋ทฐ ์์ ์๊ฐ๐ฏ 1 (Trivial) | โฑ๏ธ ~3๋ถ Poem
๐ฅ Pre-merge checks | โ 5โ Passed checks (5 passed)
โ๏ธ Tip: You can configure your own custom pre-merge checks in the settings. โจ Finishing Touches๐ Generate docstrings
๐งช Generate unit tests (beta)
โจ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
|
์ต์ upstream/main ๊ธฐ์ค์ผ๋ก ์ด PR ๋ธ๋์น(palette-a11y-overview-stats-18417779644745569749)๋ 95๊ฐ ํ์ผ์ stale diff๋ฅผ ํฌํจํฉ๋๋ค. ํนํ .claude agent/skill ํ์ผ ์ญ์ ์ ์ค๋๋ lockfile/env/code ๋ณ๊ฒฝ์ด ์์ฌ ์์ด ๊ทธ๋๋ก ์ ์งํ๊ฑฐ๋ upstream์ ์ฌ๋ฆฌ๋ฉด ์ด๋ฏธ ๋ฐ์๋ ๋ณ๊ฒฝ์ ๋๋๋ฆด ์ํ์ด ํฝ๋๋ค. ํ์ฌ ํ๋ upstream #30 โ upstream #21 ์์๋ก ์ ๋ฆฌ ์ค์ ๋๋ค. ์ด PR์ ์์ด๋์ด๊ฐ ์ฌ์ ํ ํ์ํ๋ฉด ์ต์ upstream/main์์ ๋จ์ผ ๋ชฉ์ ๋ธ๋์น๋ก ๊นจ๋ํ๊ฒ ๋ค์ ์ถ์ถํ๊ฒ ์ต๋๋ค. stale PR๋ก ๋ซ์ต๋๋ค. |
What
Added accessibility attributes (
aria-expanded,aria-controls,aria-hidden) to the collapsible "What do these numbers mean?" section in the Overview Stats component.Why
To ensure screen readers can correctly identify the button as an expand/collapse toggle, know its current state, and understand which content block it controls. It also hides decorative visual icons from screen readers to reduce unnecessary noise.
Before/After
<button>with visual icons and text. Screen readers couldn't tell if it was expanded or what it controlled.Accessibility
aria-expandedandaria-controlsto the toggle button.idto the contentdivto link witharia-controls.aria-hidden="true"to the purely decorative arrow and the "click to expand" instruction to eliminate duplicative noise.PR created automatically by Jules for task 18417779644745569749 started by @seonghobae