Skip to content

๐Ÿ›ก๏ธ Sentinel: [CRITICAL] Fix hardcoded admin password#72

Closed
seonghobae wants to merge 2 commits into
mainfrom
sentinel-fix-hardcoded-admin-password-15712461706967457741
Closed

๐Ÿ›ก๏ธ Sentinel: [CRITICAL] Fix hardcoded admin password#72
seonghobae wants to merge 2 commits into
mainfrom
sentinel-fix-hardcoded-admin-password-15712461706967457741

Conversation

@seonghobae

Copy link
Copy Markdown

๐Ÿšจ Severity: CRITICAL

๐Ÿ’ก Vulnerability: Hardcoded Secrets

A plaintext, hardcoded administrator password (og9oRajx7h88v1RIj3eDgdrh9jgLYVV3) was discovered directly in the source code (packages/web/src/lib/server/admin-auth.ts).

๐ŸŽฏ Impact

Anyone with read access to the source repository or access to the compiled artifacts could trivially extract this master password and gain full administrative access to the application, completely bypassing intended security controls.

๐Ÿ”ง Fix

  1. Removed the hardcoded string from packages/web/src/lib/server/admin-auth.ts.
  2. Updated the central Zod schema in packages/web/src/lib/server/env.ts to require ADMIN_PASSWORD with a minimum length of 8 characters.
  3. Updated packages/web/src/lib/server/admin-auth.ts to read from env.ADMIN_PASSWORD. The existing export was preserved (export const ADMIN_PASSWORD = env.ADMIN_PASSWORD) to avoid breaking dependent imports.
  4. Added a placeholder ADMIN_PASSWORD=change-me-in-production to packages/web/.env.example.
  5. Injected a dummy value into the .github/workflows/ci.yml build step to prevent the Next.js build from failing during schema validation in CI.
  6. Logged this critical finding in .jules/sentinel.md to establish a persistent security baseline against hardcoded credentials.

โœ… Verification

  1. pnpm install
  2. pnpm exec prisma generate
  3. cd packages/shared && pnpm build
  4. pnpm lint and pnpm --filter @argos/web test and pnpm build pass successfully locally, confirming that the new required environment variable functions correctly without breaking tests or the production build.

PR created automatically by Jules for task 15712461706967457741 started by @seonghobae

Extracted the hardcoded `ADMIN_PASSWORD` from `admin-auth.ts` to use a validated environment variable via `env.ts`.

Also updated `.env.example` and the CI workflow to prevent breakages, and documented the learning in `.jules/sentinel.md`.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 49 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

โŒ› How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

๐Ÿšฆ How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

โ„น๏ธ Review info
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d003f893-1df3-4e62-a633-499c0c9368c6

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 220b497 and 9fdafe4.

๐Ÿ“’ Files selected for processing (7)
  • .github/workflows/ci.yml
  • .jules/sentinel.md
  • packages/web/.env.example
  • packages/web/src/app/api/admin/login/route.ts
  • packages/web/src/lib/server/admin-auth.ts
  • packages/web/src/lib/server/env.ts
  • update-auth.patch
โœจ Finishing Touches
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sentinel-fix-hardcoded-admin-password-15712461706967457741
โœจ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch sentinel-fix-hardcoded-admin-password-15712461706967457741

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands and usage tips.

Updated `admin-auth.ts` to use `pbkdf2Sync` to pre-compute the expected password hash and an async `pbkdf2` for the incoming password verification, resolving the CodeQL `js/insecure-password-hashing` alert caused by using a fast HMAC algorithm for timing-safe equality checks.
@seonghobae

Copy link
Copy Markdown
Author

์ตœ์‹  upstream/main ๊ธฐ์ค€์œผ๋กœ ์ด PR ๋ธŒ๋žœ์น˜(sentinel-fix-hardcoded-admin-password-15712461706967457741)๋Š” 97๊ฐœ ํŒŒ์ผ์˜ stale diff๋ฅผ ํฌํ•จํ•ฉ๋‹ˆ๋‹ค. ํŠนํžˆ .claude agent/skill ํŒŒ์ผ ์‚ญ์ œ์™€ ์˜ค๋ž˜๋œ lockfile/env/code ๋ณ€๊ฒฝ์ด ์„ž์—ฌ ์žˆ์–ด ๊ทธ๋Œ€๋กœ ์œ ์ง€ํ•˜๊ฑฐ๋‚˜ upstream์— ์˜ฌ๋ฆฌ๋ฉด ์ด๋ฏธ ๋ฐ˜์˜๋œ ๋ณ€๊ฒฝ์„ ๋˜๋Œ๋ฆด ์œ„ํ—˜์ด ํฝ๋‹ˆ๋‹ค.

ํ˜„์žฌ ํ๋Š” upstream #30 โ†’ upstream #21 ์ˆœ์„œ๋กœ ์ •๋ฆฌ ์ค‘์ž…๋‹ˆ๋‹ค. ์ด PR์˜ ์•„์ด๋””์–ด๊ฐ€ ์—ฌ์ „ํžˆ ํ•„์š”ํ•˜๋ฉด ์ตœ์‹  upstream/main์—์„œ ๋‹จ์ผ ๋ชฉ์  ๋ธŒ๋žœ์น˜๋กœ ๊นจ๋—ํ•˜๊ฒŒ ๋‹ค์‹œ ์ถ”์ถœํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. stale PR๋กœ ๋‹ซ์Šต๋‹ˆ๋‹ค.

@seonghobae seonghobae closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant