๐ก๏ธ Sentinel: [CRITICAL] Fix hardcoded admin password#72
๐ก๏ธ Sentinel: [CRITICAL] Fix hardcoded admin password#72seonghobae wants to merge 2 commits into
Conversation
Extracted the hardcoded `ADMIN_PASSWORD` from `admin-auth.ts` to use a validated environment variable via `env.ts`. Also updated `.env.example` and the CI workflow to prevent breakages, and documented the learning in `.jules/sentinel.md`.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 25 minutes and 49 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. โ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. ๐ฆ How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. โน๏ธ Review infoโ๏ธ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ๐ Files selected for processing (7)
โจ Finishing Touches๐งช Generate unit tests (beta)
โจ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Updated `admin-auth.ts` to use `pbkdf2Sync` to pre-compute the expected password hash and an async `pbkdf2` for the incoming password verification, resolving the CodeQL `js/insecure-password-hashing` alert caused by using a fast HMAC algorithm for timing-safe equality checks.
|
์ต์ upstream/main ๊ธฐ์ค์ผ๋ก ์ด PR ๋ธ๋์น(sentinel-fix-hardcoded-admin-password-15712461706967457741)๋ 97๊ฐ ํ์ผ์ stale diff๋ฅผ ํฌํจํฉ๋๋ค. ํนํ .claude agent/skill ํ์ผ ์ญ์ ์ ์ค๋๋ lockfile/env/code ๋ณ๊ฒฝ์ด ์์ฌ ์์ด ๊ทธ๋๋ก ์ ์งํ๊ฑฐ๋ upstream์ ์ฌ๋ฆฌ๋ฉด ์ด๋ฏธ ๋ฐ์๋ ๋ณ๊ฒฝ์ ๋๋๋ฆด ์ํ์ด ํฝ๋๋ค. ํ์ฌ ํ๋ upstream #30 โ upstream #21 ์์๋ก ์ ๋ฆฌ ์ค์ ๋๋ค. ์ด PR์ ์์ด๋์ด๊ฐ ์ฌ์ ํ ํ์ํ๋ฉด ์ต์ upstream/main์์ ๋จ์ผ ๋ชฉ์ ๋ธ๋์น๋ก ๊นจ๋ํ๊ฒ ๋ค์ ์ถ์ถํ๊ฒ ์ต๋๋ค. stale PR๋ก ๋ซ์ต๋๋ค. |
๐จ Severity: CRITICAL
๐ก Vulnerability: Hardcoded Secrets
A plaintext, hardcoded administrator password (
og9oRajx7h88v1RIj3eDgdrh9jgLYVV3) was discovered directly in the source code (packages/web/src/lib/server/admin-auth.ts).๐ฏ Impact
Anyone with read access to the source repository or access to the compiled artifacts could trivially extract this master password and gain full administrative access to the application, completely bypassing intended security controls.
๐ง Fix
packages/web/src/lib/server/admin-auth.ts.packages/web/src/lib/server/env.tsto requireADMIN_PASSWORDwith a minimum length of 8 characters.packages/web/src/lib/server/admin-auth.tsto read fromenv.ADMIN_PASSWORD. The existing export was preserved (export const ADMIN_PASSWORD = env.ADMIN_PASSWORD) to avoid breaking dependent imports.ADMIN_PASSWORD=change-me-in-productiontopackages/web/.env.example..github/workflows/ci.ymlbuild step to prevent the Next.js build from failing during schema validation in CI..jules/sentinel.mdto establish a persistent security baseline against hardcoded credentials.โ Verification
pnpm installpnpm exec prisma generatecd packages/shared && pnpm buildpnpm lintandpnpm --filter @argos/web testandpnpm buildpass successfully locally, confirming that the new required environment variable functions correctly without breaking tests or the production build.PR created automatically by Jules for task 15712461706967457741 started by @seonghobae