🛡️ Sentinel: [CRITICAL] Remove hardcoded admin password

[seonghobae]

🚨 Severity: CRITICAL

💡 Vulnerability: A hardcoded plaintext password (ADMIN_PASSWORD) was stored directly in the packages/web/src/lib/server/admin-auth.ts file. This is a critical security vulnerability that exposes administrative credentials if the source code is compromised or leaked.

🎯 Impact: An attacker with access to the source code could use this hardcoded password to log into the application as an administrator, granting them full unauthorized access to sensitive administrative functionality and data.

🔧 Fix:

• Removed the hardcoded plaintext ADMIN_PASSWORD from packages/web/src/lib/server/admin-auth.ts.
• Introduced ADMIN_PASSWORD as a required environment variable via Zod validation (EnvSchema in env.ts) enforcing a minimum length of 32 characters for strong security.
• Updated the verification logic to dynamically compare against env.ADMIN_PASSWORD.
• Added the placeholder ADMIN_PASSWORD to .env.example to ease local development setup.
• Updated .github/workflows/ci.yml to supply a dummy ADMIN_PASSWORD to the Next.js build step, preventing CI pipeline failures due to the new strict Zod schema constraints.

✅ Verification:

• Ran the type checker, linter (pnpm lint), and test suites (pnpm --filter @argos/web test).
• Verified a successful production build with next build.
• No hardcoded secrets persist in the codebase.

---

PR created automatically by Jules for task 13555713082328396983 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 15 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 14c92e73-9144-4967-b194-3f6d7a81d9e9

📥 Commits

Reviewing files that changed from the base of the PR and between 220b497 and 1385e2a.

📒 Files selected for processing (6)

• .github/workflows/ci.yml
• .jules/sentinel.md
• packages/web/.env.example
• packages/web/src/app/api/admin/login/route.ts
• packages/web/src/lib/server/admin-auth.ts
• packages/web/src/lib/server/env.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-remove-hardcoded-admin-password-13555713082328396983

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch sentinel-remove-hardcoded-admin-password-13555713082328396983

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[seonghobae]

최신 upstream/main 기준으로 이 PR 브랜치(sentinel-remove-hardcoded-admin-password-13555713082328396983)는 96개 파일의 stale diff를 포함합니다. 특히 .claude agent/skill 파일 삭제와 오래된 lockfile/env/code 변경이 섞여 있어 그대로 유지하거나 upstream에 올리면 이미 반영된 변경을 되돌릴 위험이 큽니다.

현재 큐는 upstream #30 → upstream #21 순서로 정리 중입니다. 이 PR의 아이디어가 여전히 필요하면 최신 upstream/main에서 단일 목적 브랜치로 깨끗하게 다시 추출하겠습니다. stale PR로 닫습니다.