chore(deps): align React 19 upgrade by seonghobae · Pull Request #22 · ContextualWisdomLab/bandscope

seonghobae · 2026-03-11T05:49:37Z

Summary

combine the split React 19 Dependabot updates into one repo-owned branch
align react, react-dom, @types/react, and @types/react-dom on 19.x
add root peer-resolution support so testing-library uses the same React 19 tree during CI

Supersedes

Verification

./scripts/harness/quickcheck.sh

Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together. Updates `react` from 18.3.1 to 19.2.4 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.4/packages/react) Updates `@types/react` from 18.3.28 to 19.2.14 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: react dependency-version: 19.2.4 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react" dependency-version: 19.2.14 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.2.4 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.4/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-version: 19.2.4 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

coderabbitai · 2026-03-11T05:49:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 23bda889-8086-4a3a-bc9e-2408902a1242

📥 Commits

Reviewing files that changed from the base of the PR and between 7afe00b and b5c01dd.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

apps/desktop/package.json

📝 Walkthrough

Summary by CodeRabbit

Chores
- React 및 React DOM을 19.2.4로 업그레이드했습니다.
- 관련 타입 정의(@types)도 최신 19.x 버전으로 업데이트했습니다.
- 개발환경 의존성 목록에 React 관련 패키지를 추가했습니다.

Walkthrough

데스크톱 앱과 루트 패키지의 package.json에서 React 및 React DOM 의존성을 18.x에서 19.x로 업그레이드하고, 루트 package.json에 React/React DOM을 devDependencies로 추가했습니다. 타입 패키지(@types/*)도 19.x로 맞췄습니다. (변경: +4 / -4)

Changes

Cohort / File(s)	Summary
앱 데스크톱 패키지 업데이트 `apps/desktop/package.json`	`react` 및 `react-dom`을 ^18.3.1 → ^19.2.4로 업데이트; 관련 `@types/react`, `@types/react-dom`도 19.x로 상향 조정.
루트 패키지 devDependencies 추가 `package.json`	루트 `package.json`에 `devDependencies` 항목으로 `"react": "^19.2.4"`, `"react-dom": "^19.2.4"` 추가. 변경은 의존성 선언에 국한됨.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

시

🐰 업그레이드 토끼가 말하네,
열아홉의 리액트로 깡충깡충,
타입도 함께 맞추며,
패키지에 새 옷을 입혔네. ✨🐇

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	제목이 주요 변경사항인 React 19 업그레이드 정렬을 명확하게 반영합니다.
Description check	✅ Passed	설명이 React 패키지 버전 정렬, Dependabot 업데이트 통합, peer-resolution 지원 추가 등 변경사항과 관련이 있습니다.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch deps/react19-alignment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

seonghobae · 2026-03-11T06:01:23Z

@coderabbitai review

coderabbitai · 2026-03-11T06:01:33Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Around line 30-32: The root package.json currently lists react and react-dom
under devDependencies but that doesn't force a single version across npm
workspaces; add an "overrides" section in the root package.json that pins both
"react" and "react-dom" to the desired version (e.g., "19.2.4") so all
workspaces resolve the same packages; update the "overrides" key in package.json
to include entries for "react" and "react-dom" (and any scope-specific
exceptions if needed) and run npm install to verify a single React tree across
workspaces.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5ea87e3c-b5cd-4378-b478-c8b8fdc1ff90

📥 Commits

Reviewing files that changed from the base of the PR and between d77d678 and 7afe00b.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

apps/desktop/package.json
package.json

seonghobae · 2026-03-11T06:14:16Z

@coderabbitai pause

seonghobae · 2026-03-11T06:14:18Z

@coderabbitai resume

coderabbitai · 2026-03-11T06:14:24Z

✅ Actions performed

Reviews paused.

coderabbitai · 2026-03-11T06:14:29Z

✅ Actions performed

Reviews resumed.

seonghobae · 2026-03-11T06:18:31Z

@coderabbitai review

coderabbitai · 2026-03-11T06:18:38Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

seonghobae · 2026-03-11T06:21:29Z

@coderabbitai review

coderabbitai · 2026-03-11T06:21:44Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

seonghobae · 2026-03-11T06:32:46Z

@coderabbitai pause

seonghobae · 2026-03-11T06:32:48Z

@coderabbitai resume

seonghobae · 2026-03-11T06:32:49Z

@coderabbitai resolve

coderabbitai · 2026-03-11T06:35:43Z

✅ Actions performed

Reviews paused.

coderabbitai · 2026-03-11T06:36:14Z

✅ Actions performed

Reviews resumed.

coderabbitai · 2026-03-11T06:36:21Z

✅ Actions performed

Comments resolved and changes approved.

seonghobae · 2026-03-11T06:41:33Z

@coderabbitai review

coderabbitai · 2026-03-11T06:41:42Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

dependabot Bot and others added 3 commits March 11, 2026 03:57

chore: combine React 19 dependency updates

7afe00b

This was referenced Mar 11, 2026

chore(deps): bump react and @types/react #7

Closed

chore(deps): bump react-dom and @types/react-dom #12

Closed

seonghobae enabled auto-merge March 11, 2026 06:01

coderabbitai Bot suggested changes Mar 11, 2026

View reviewed changes

Comment thread package.json

chore: rebase React 19 upgrade onto current develop

b5c01dd

seonghobae merged commit 77df413 into develop Mar 11, 2026
16 checks passed

coderabbitai Bot approved these changes Mar 11, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Jun 10, 2026

chore(deps): bump react-dom from 19.2.5 to 19.2.7 #240

Merged

Conversation

seonghobae commented Mar 11, 2026

Summary

Supersedes

Verification

Uh oh!

coderabbitai Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

시

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

seonghobae commented Mar 11, 2026

Uh oh!

coderabbitai Bot commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Mar 11, 2026 •

edited

Loading