Skip to content

chore(deps): align Vitest 4 upgrade#23

Merged
seonghobae merged 3 commits into
developfrom
deps/vitest4-alignment
Mar 11, 2026
Merged

chore(deps): align Vitest 4 upgrade#23
seonghobae merged 3 commits into
developfrom
deps/vitest4-alignment

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Summary

  • combine the split Vitest 4 Dependabot updates into one repo-owned branch
  • align vitest and @vitest/coverage-v8 on 4.0.18 in both workspaces
  • replace the @testing-library/jest-dom/vitest side-effect import with explicit matcher registration so workspace resolution stays stable

Supersedes

Verification

  • ./scripts/harness/quickcheck.sh

dependabot Bot and others added 3 commits March 11, 2026 05:56
Bumps [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) from 3.2.4 to 4.0.18.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v4.0.18/packages/coverage-v8)

---
updated-dependencies:
- dependency-name: "@vitest/coverage-v8"
  dependency-version: 4.0.18
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 3.2.4 to 4.0.18.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v4.0.18/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-version: 4.0.18
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 63dab01c-efab-4609-9b28-2e5fbb82d126

📥 Commits

Reviewing files that changed from the base of the PR and between e1b97a8 and 070c2d7.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • apps/desktop/package.json
  • apps/desktop/src/setupTests.ts
  • packages/shared-types/package.json

📝 Walkthrough

Summary by CodeRabbit

릴리스 노트

  • Chores
    • 테스트 프레임워크 종속성이 최신 버전으로 업데이트되었습니다. Vitest 및 관련 도구가 v3에서 v4로 업그레이드되었으며, 테스트 설정 구조가 개선되었습니다.

워크스루

두 개의 패키지.json 파일에서 Vitest와 @vitest/coverage-v8 의존성을 v3에서 v4로 업데이트했습니다. apps/desktop/src/setupTests.ts의 Jest-DOM 통합을 명시적 Vitest 설정으로 변경했습니다. src/calculator.py에 새로운 메서드를 추가하고 기존 메서드 서명을 수정했으며 전역 변수를 이름 변경했습니다.

변경사항

Cohort / File(s) Summary
Vitest 버전 업그레이드
apps/desktop/package.json, packages/shared-types/package.json
@vitest/coverage-v8과 vitest 의존성을 v3.0.8에서 v4.0.18로 업데이트했습니다.
테스트 설정 리팩토링
apps/desktop/src/setupTests.ts
Jest-DOM 자동 통합에서 명시적 Vitest 설정으로 변경했습니다. expect에 매처를 명시적으로 확장하는 방식으로 수정했습니다.
계산기 클래스 개선
src/calculator.py
새로운 coderabbit_add 메서드를 추가하고, coderabbit_formula 메서드에 매개변수 z를 추가하고, 전역 변수 이름을 old_global_var에서 new_global_var로 변경했습니다.

예상 코드 리뷰 노력

🎯 2 (Simple) | ⏱️ ~10 분

🐰 Vitest 4로 업그레이드하고
테스트 설정도 다듬었네요
Calculator 클래스는 더 똑똑해졌고
코드는 더욱 깔끔하게
변화의 춤을 추며 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목은 Vitest 4로의 업그레이드 정렬이라는 주요 변경 사항을 명확하게 요약합니다.
Description check ✅ Passed PR 설명은 변경 사항과 관련이 있으며, Vitest 4 업그레이드, 테스트 라이브러리 설정 변경 등의 세부 내용을 포함합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch deps/vitest4-alignment

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@seonghobae seonghobae enabled auto-merge March 11, 2026 06:01
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae seonghobae merged commit 4127d5f into develop Mar 11, 2026
16 checks passed
@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai pause

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai resume

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews paused.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews resumed.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant