[WIP] Add advanced rehearsal collaboration features#325
Closed
Claude wants to merge 4 commits into
Closed
Conversation
…types Adds V2 advanced rehearsal collaboration contracts: - CollaborationSession, RehearsalComment, PlayerAssignment, RoleApproval types - Validation functions with strict field checking - Factory helpers: createCollaborationSession, createRehearsalComment, createPlayerAssignment, createRoleApproval - Comprehensive test coverage for all new types and validators Agent-Logs-Url: https://github.com/Seongho-Bae/bandscope/sessions/1cfe246a-04a9-4a53-8861-1496bc130f1f Co-authored-by: seonghobae <8172694+seonghobae@users.noreply.github.com>
- CommentThread: displays threaded comments with resolve actions - AssignmentPanel: shows role assignments with status badges - ApprovalList: shows section/role approvals with reviewer info - CollaborationPanel: composes all sub-components into unified view - i18n: add EN and KO translations for all collaboration UI strings - Tests: 17 component tests covering all collaboration UI states Agent-Logs-Url: https://github.com/Seongho-Bae/bandscope/sessions/1cfe246a-04a9-4a53-8861-1496bc130f1f Co-authored-by: seonghobae <8172694+seonghobae@users.noreply.github.com>
Split combined sectionId/roleId check into separate validations so the correct field name is reported when either is missing. Agent-Logs-Url: https://github.com/Seongho-Bae/bandscope/sessions/1cfe246a-04a9-4a53-8861-1496bc130f1f Co-authored-by: seonghobae <8172694+seonghobae@users.noreply.github.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.