Refresh Tauri lockfile while keeping the glib 0.18.5 RustSec exception narrow#327
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refreshes the Tauri desktop Rust dependency lockfile while keeping the documented RUSTSEC-2024-0429 (glib 0.18.5) exception explicitly scoped to the upstream GTK3/WebKit dependency chain, and updates the repo-controlled policy evidence + guardrail test to match the new state.
Changes:
- Refresh
apps/desktop/src-tauri/Cargo.lockto a newer compatible patch set (includingtauri 2.11.2,wry 0.55.1,tao 0.35.3,muda 0.19.2, plus transitive updates). - Update
docs/security/dependency-policy.mdto record that a compatible lockfile refresh exists but still cannot reach patchedglib >=0.20.0due to upstream chain constraints. - Update
services/analysis-engine/tests/test_supply_chain_policy.pyto assert the new documented evidence string(s) instead of the prior “no compatible lockfile-only update” wording.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/analysis-engine/tests/test_supply_chain_policy.py | Updates the supply-chain policy guardrail assertions to match the refreshed lockfile evidence language. |
| docs/security/dependency-policy.md | Updates the documented scope/justification for the narrow glib 0.18.5 RustSec exception after a compatible lockfile refresh. |
| apps/desktop/src-tauri/Cargo.lock | Refreshes the desktop Rust lockfile to newer compatible patch versions while retaining the upstream-owned glib 0.18.5 chain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OpenCode Review Overview
Pull request overviewPR updates Rust dependencies and documentation. The autocfg crate update is a patch version bump with no breaking changes. Policy doc and test changes are minor and non-functional. Structural analysis shows no call chain impacts. FindingsNo blocking findings from OpenCode's independent review. Verification
Gate evidence
|
There was a problem hiding this comment.
Pull request overview
PR updates Rust dependencies and documentation. The autocfg crate update is a patch version bump with no breaking changes. Policy doc and test changes are minor and non-functional. Structural analysis shows no call chain impacts.
Findings
No blocking findings from OpenCode's independent review.
Verification
- Review source: independent OpenCode review of the current checkout, focused changed hunks, and current-head GitHub Check evidence.
- Structural exploration: completed before approval; if structural exploration, changed-file inspection, or evidence completeness is missing, OpenCode must not approve.
- Result: APPROVE
- Reason: Minor dependency updates with no detected risks
Gate evidence
- Head SHA:
8bb9c0b6c7204f52af04883684ec6c3cf8418d64 - Workflow run: 27753520530
- Workflow attempt: 1
|
Merge evidence for current head
Security Notes:
|
RUSTSEC-2024-0429forglib 0.18.5remains upstream-owned in the Tauri GTK/WebKit stack even after the latest compatible desktop lockfile refresh. This change updates the lockfile and repo-controlled policy evidence so the exception stays narrow, documented, and removable when upstream moves to patchedglib >=0.20.0. It does not close the tracker issue yet because the vulnerable upstream-owned chain is still present.Compatible desktop lockfile refresh
apps/desktop/src-tauri/Cargo.lockto the latest compatible patch set available from the current dependency constraints.tauri 2.11.3wry 0.55.1tao 0.35.3muda 0.19.3Supply-chain policy evidence
docs/security/dependency-policy.mdto reflect the new state:glib 0.18.5Guardrail expectation update
services/analysis-engine/tests/test_supply_chain_policy.pyso the policy test asserts the new documented evidence instead of stale version wording.Security Notes:
glibversions are non-numeric, below patched range, unowned, or owned by unexpected packages.python3 scripts/checks/verify_supply_chain.py,uv run --project services/analysis-engine pytest services/analysis-engine/tests/test_supply_chain_policy.py -q,cargo tree --manifest-path apps/desktop/src-tauri/Cargo.toml --target all -i glib@0.18.5, andcargo audit --no-fetch --stale.Refs #196.