Skip to content

ci: state mandatory structural exploration in reviews#349

Merged
seonghobae merged 1 commit into
developfrom
opencode-structural-review-copy
Jun 18, 2026
Merged

ci: state mandatory structural exploration in reviews#349
seonghobae merged 1 commit into
developfrom
opencode-structural-review-copy

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Summary

  • add explicit structural-exploration verification lines to OpenCode REQUEST_CHANGES review bodies
  • add explicit structural-exploration completion and no-approval-without-structure wording to OpenCode APPROVE review bodies

Verification

  • bash -n scripts/ci/opencode_review_approve_gate.sh
  • python3 -m py_compile scripts/ci/opencode_review_normalize_output.py
  • git diff --check -- .github/workflows/opencode-review.yml

Security Notes

  • This changes GitHub Actions review text only; it does not add runtime code, file handling, subprocess invocation, IPC, WebView, model download, or export behavior.
  • The trust boundary remains the existing CI workflow and OpenCode review gate. The change makes the existing structural-review requirement explicit in the review output so missing structural evidence is not presented as acceptable.
  • Test points are workflow text generation paths for APPROVE and REQUEST_CHANGES plus the existing approve-gate/normalizer syntax checks.

Copilot AI review requested due to automatic review settings June 18, 2026 07:19
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 52 minutes and 26 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 582bb12f-e037-4d92-9b20-8e6e63552373

📥 Commits

Reviewing files that changed from the base of the PR and between aeea6b5 and b0de01d.

📒 Files selected for processing (1)
  • .github/workflows/opencode-review.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch opencode-structural-review-copy
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch opencode-structural-review-copy

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OpenCode review text emitted by the opencode-review GitHub Actions workflow to make the repository’s “structural exploration” requirement explicit in both REQUEST_CHANGES and APPROVE review bodies, so reviews don’t appear acceptable when structural evidence is missing.

Changes:

  • Add an explicit “Structural exploration” verification bullet to REQUEST_CHANGES review bodies.
  • Add an explicit “Structural exploration completed / must not approve without it” verification bullet to APPROVE review bodies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@seonghobae seonghobae force-pushed the opencode-structural-review-copy branch from 1992402 to b0de01d Compare June 18, 2026 07:21
@opencode-agent

opencode-agent Bot commented Jun 18, 2026

Copy link
Copy Markdown

OpenCode Review Overview

  • Head SHA: b0de01d481912d677c963dea55857cd14ed588a6
  • Workflow run: 27743487442
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

Pull request overview

The changes in PR #349 are minimal and do not introduce any issues. The workflow update is safe and does not affect existing functionality.

Findings

No blocking findings from OpenCode's independent review.

Verification

  • Review source: independent OpenCode review of the current checkout, focused changed hunks, and current-head GitHub Check evidence.
  • Structural exploration: completed before approval; if structural exploration, changed-file inspection, or evidence completeness is missing, OpenCode must not approve.
  • Result: APPROVE
  • Reason: No source-backed blockers found. Structural exploration completed.

Gate evidence

  • Head SHA: b0de01d481912d677c963dea55857cd14ed588a6
  • Workflow run: 27743487442
  • Workflow attempt: 1

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

The changes in PR #349 are minimal and do not introduce any issues. The workflow update is safe and does not affect existing functionality.

Findings

No blocking findings from OpenCode's independent review.

Verification

  • Review source: independent OpenCode review of the current checkout, focused changed hunks, and current-head GitHub Check evidence.
  • Structural exploration: completed before approval; if structural exploration, changed-file inspection, or evidence completeness is missing, OpenCode must not approve.
  • Result: APPROVE
  • Reason: No source-backed blockers found. Structural exploration completed.

Gate evidence

  • Head SHA: b0de01d481912d677c963dea55857cd14ed588a6
  • Workflow run: 27743487442
  • Workflow attempt: 1

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Merge evidence for current head b0de01d481912d677c963dea55857cd14ed588a6:\n\n- Required checks passed: CodeQL, ci/build-and-test, dependency-review, gate/build macOS, gate/build Windows, release-preflight, sbom, security-audit, trivy-fs-scan, and the related security/supply-chain checks.\n- OpenCode approved the current head in run 27743487442. The generated overview and PR review now explicitly include: Structural exploration: completed before approval; if structural exploration, changed-file inspection, or evidence completeness is missing, OpenCode must not approve.\n- Review threads: zero unresolved threads.\n- Structural scope: one workflow text-generation change in .github/workflows/opencode-review.yml; it adds fixed verification bullets to REQUEST_CHANGES and APPROVE review bodies. No runtime app code, file handling, IPC, WebView, subprocess surface, model download, export behavior, or dependency changes.\n- Local verification before opening the PR: bash -n scripts/ci/opencode_review_approve_gate.sh, python3 -m py_compile scripts/ci/opencode_review_normalize_output.py, and git diff --check -- .github/workflows/opencode-review.yml.\n- Scorecard workflow and SARIF upload passed; the branch-protection code-scanning Scorecard check remains neutral/skipping while CodeQL and Trivy code-scanning are successful.

@seonghobae seonghobae merged commit 5b94364 into develop Jun 18, 2026
26 checks passed
@seonghobae seonghobae deleted the opencode-structural-review-copy branch June 18, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants