Block OpenCode approval on stale fact evidence#362
Merged
Conversation
OpenCode Review Overview
Pull request overviewThe changes in PR #362 include updates to the OpenCode review workflow and a new test script. Structural exploration confirmed no regressions or broken contracts. No failed GitHub Checks were present. FindingsNo blocking findings from OpenCode's independent review. Verification
Gate evidence
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
The changes in PR #362 include updates to the OpenCode review workflow and a new test script. Structural exploration confirmed no regressions or broken contracts. No failed GitHub Checks were present.
Findings
No blocking findings from OpenCode's independent review.
Verification
- Review source: independent OpenCode review of the current checkout, focused changed hunks, and current-head GitHub Check evidence.
- Structural exploration: completed before approval; if structural exploration, changed-file inspection, or evidence completeness is missing, OpenCode must not approve.
- Result: APPROVE
- Reason: No source-backed blockers found; structural exploration completed.
Gate evidence
- Head SHA:
b02b02ac2148336a8cf44fcbcbf5758228b7bac2 - Workflow run: 27892016371
- Workflow attempt: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This rolls out the org-level fix proven in ContextualWisdomLab/naruon#664. The failing mode was: OpenCode prepared evidence, a human review thread arrived afterward, and approval still happened without a fresh thread/fact check.
Branch model
developValidation
bash scripts/ci/test_opencode_fact_gate_contract.shgit diff --check -- .github/workflows/opencode-review.yml scripts/ci/test_opencode_fact_gate_contract.shactionlint -shellcheck "" .github/workflows/opencode-review.yml