[codex] Require OpenCode inline suggested diffs#365
Merged
Conversation
OpenCode Review Overview
Pull request overviewPR #365 introduces changes to shared types and review scheduling logic, with no test coverage gaps or structural risks identified. FindingsNo blocking findings from OpenCode's independent review. Verification
Gate evidence
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
PR #365 introduces changes to shared types and review scheduling logic, with no test coverage gaps or structural risks identified.
Findings
No blocking findings from OpenCode's independent review.
Verification
- Review source: independent OpenCode review of the current checkout, focused changed hunks, and current-head GitHub Check evidence.
- Structural exploration: completed before approval; if structural exploration, changed-file inspection, or evidence completeness is missing, OpenCode must not approve.
- Result: APPROVE
- Reason: No source-backed blockers found. Structural exploration completed without issues.
Gate evidence
- Head SHA:
82284ee9e38f1a0cb84c70926f6f5c916ce58933 - Workflow run: 27900421255
- Workflow attempt: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
REQUEST_CHANGESfindings through GitHub reviewcommentsso each finding'ssuggested_diffis inside the inline review thread comment.REQUEST_CHANGESbody when GitHub rejects inline anchors, instead of silently approving or copying unanchored diffs into the overview.Contract
Line-specific OpenCode findings with
suggested_diffmust publish as GitHub review comments withpath,line,side: RIGHT, and a comment body containing the fenced diff. If the anchor cannot be created, the workflow leaves the diff out of the PR-level body and explains the anchor failure.Validation
git diff --check.github/workflows/opencode-review.ymlcommentspayload exists, inline comment body contains#### Suggested diff, andformat_request_changes_body()no longer contains a fenced diff block.