Skip to content

⚡ perf(desktop): optimize mock song lookup from O(N) to O(1) #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −10
Open

⚡ perf(desktop): optimize mock song lookup from O(N) to O(1) #398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions apps/desktop/src/lib/job_runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,22 +36,16 @@ const mockWorkspace: RehearsalWorkspace = {
workspaceVersion: 1
};

const mockSongsById = new Map<string, SongRehearsalPack>();
const mockSongsById = new Map<string, SongRehearsalPack>(
mockWorkspace.songs.map(song => [song.id, song])
);

type MockListener = (event: { payload: unknown }) => void;
const mockListeners = new Set<MockListener>();

/** Documented. */
function getMockSong(jobId: string): SongRehearsalPack | undefined {
const cachedPack = mockSongsById.get(jobId);
if (cachedPack) {
return cachedPack;
}
const pack = mockWorkspace.songs.find(song => song.id === jobId);
if (pack) {
mockSongsById.set(jobId, pack);
}
return pack;
return mockSongsById.get(jobId);
}

/**
Expand Down