Skip to content

🧹 Split oversized test function to improve readability and granularity #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 1 commit into
base: develop
Choose a base branch
from
+67 −39
Open

🧹 Split oversized test function to improve readability and granularity #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 67 additions & 39 deletions services/analysis-engine/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ def test_validate_analysis_job_request_accepts_local_audio_payload() -> None:
}


def test_validate_analysis_job_request_rejects_bad_payloads() -> None:
"""Ensure the request validator reports every expected safe-failure path."""
def test_validate_analysis_job_request_rejects_bad_generic_fields() -> None:
"""Ensure the request validator reports failures for bad generic payload structures."""
cases = [
([], "root"),
({}, "sourceKind"),
Expand All @@ -93,6 +93,71 @@ def test_validate_analysis_job_request_rejects_bad_payloads() -> None:
({"sourceKind": "demo", "sourceLabel": " ", "roleFocus": []}, "sourceLabel"),
({"sourceKind": "demo", "sourceLabel": "Late Night Set", "roleFocus": {}}, "roleFocus"),
({"sourceKind": "demo", "sourceLabel": "Late Night Set", "roleFocus": [7]}, "roleFocus[0]"),
]

for payload, message in cases:
try:
validate_analysis_job_request(payload)
except ValueError as error:
assert message in str(error)
else:
raise AssertionError(f"Expected ValueError for {payload!r}")


def test_validate_analysis_job_request_rejects_bad_demo_fields() -> None:
"""Ensure the request validator reports failures for bad demo payloads."""
cases = [
(
{
"sourceKind": "demo",
"projectId": "project-1",
"sourceLabel": "Late Night Set",
"roleFocus": [],
"localSource": {
"sourcePath": "/Users/test/Music/late-night-set.wav",
"fileName": "late-night-set.wav",
"extension": "wav",
"fileSizeBytes": 1024000,
},
},
"projectId",
),
(
{"sourceKind": "demo", "sourceLabel": "Late Night Set", "roleFocus": [], "extra": True},
"extra",
),
(
{
"sourceKind": "demo",
"sourceLabel": "Late Night Set",
"roleFocus": [],
"cacheRoot": "/tmp/bandscope/cache",
},
"cacheRoot",
),
(
{
"sourceKind": "demo",
"sourceLabel": "Late Night Set",
"roleFocus": [],
"tempRoot": "/tmp/bandscope/temp",
},
"tempRoot",
),
]

for payload, message in cases:
try:
validate_analysis_job_request(payload)
except ValueError as error:
assert message in str(error)
else:
raise AssertionError(f"Expected ValueError for {payload!r}")


def test_validate_analysis_job_request_rejects_bad_local_audio_fields() -> None:
"""Ensure the request validator reports failures for bad local_audio payloads."""
cases = [
(
{"sourceKind": "local_audio", "sourceLabel": "Late Night Set", "roleFocus": []},
"projectId",
Expand Down Expand Up @@ -192,43 +257,6 @@ def test_validate_analysis_job_request_rejects_bad_payloads() -> None:
},
"localSource.extra",
),
(
{
"sourceKind": "demo",
"projectId": "project-1",
"sourceLabel": "Late Night Set",
"roleFocus": [],
"localSource": {
"sourcePath": "/Users/test/Music/late-night-set.wav",
"fileName": "late-night-set.wav",
"extension": "wav",
"fileSizeBytes": 1024000,
},
},
"projectId",
),
(
{"sourceKind": "demo", "sourceLabel": "Late Night Set", "roleFocus": [], "extra": True},
"extra",
),
(
{
"sourceKind": "demo",
"sourceLabel": "Late Night Set",
"roleFocus": [],
"cacheRoot": "/tmp/bandscope/cache",
},
"cacheRoot",
),
(
{
"sourceKind": "demo",
"sourceLabel": "Late Night Set",
"roleFocus": [],
"tempRoot": "/tmp/bandscope/temp",
},
"tempRoot",
),
(
{
"sourceKind": "local_audio",
Expand Down