Skip to content

⚡ Optimize YouTube import to eliminate redundant network calls #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −11
Open

⚡ Optimize YouTube import to eliminate redundant network calls #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/analysis-engine/src/bandscope_analysis/youtube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def download_youtube_audio(url: str, out_dir: str) -> Dict[str, Any]:
},
}

info = ydl.extract_info(url, download=True)
info = ydl.process_ie_result(info, download=True)
if info is None:
raise Exception("Failed to extract info")
actual_filepath = ydl.prepare_filename(info)
Expand Down
18 changes: 8 additions & 10 deletions services/analysis-engine/tests/test_youtube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def test_download_youtube_audio_success(
"duration": 60,
}
mock_ydl.extract_info.return_value = mock_info
mock_ydl.process_ie_result.return_value = mock_info
mock_ydl.prepare_filename.return_value = "/tmp/abc123DEF45.webm"
mock_exists.return_value = True
mock_getsize.return_value = 10 * 1024 * 1024
Expand All @@ -111,16 +112,11 @@ def test_download_youtube_audio_success(
assert called_opts["postprocessors"] == [{"key": "FFmpegExtractAudio"}]
assert "%(id)s.%(ext)s" in called_opts["outtmpl"]

# Verify extract_info was called twice correctly: once for metadata, once for download
from unittest.mock import call
# Verify extract_info was called once for metadata, and process_ie_result once for download

assert mock_ydl.extract_info.call_count == 2
mock_ydl.extract_info.assert_has_calls(
[
call(input_url, download=False),
call(input_url, download=True),
]
)
assert mock_ydl.extract_info.call_count == 1
mock_ydl.extract_info.assert_called_with(input_url, download=False)
mock_ydl.process_ie_result.assert_called_with(mock_info, download=True)


@patch("bandscope_analysis.youtube.os.path.getsize")
Expand Down Expand Up @@ -349,6 +345,7 @@ def test_module_execution(
mock_ydl = MagicMock()
mock_yt_dlp.YoutubeDL.return_value.__enter__.return_value = mock_ydl
mock_ydl.extract_info.return_value = {"id": "abc123DEF45"}
mock_ydl.process_ie_result.return_value = {"id": "abc123DEF45"}
mock_ydl.prepare_filename.return_value = "/tmp/abc123DEF45.m4a"
monkeypatch.setitem(sys.modules, "yt_dlp", mock_yt_dlp)

Expand Down Expand Up @@ -379,7 +376,8 @@ def test_download_youtube_audio_second_info_none(mock_ydl_class: MagicMock) -> N
mock_ydl_class.return_value.__enter__.return_value = mock_ydl

# First call (download=False) returns info, second call (download=True) returns None
mock_ydl.extract_info.side_effect = [{"duration": 60}, None]
mock_ydl.extract_info.return_value = {"duration": 60}
mock_ydl.process_ie_result.return_value = None

result = download_youtube_audio("https://youtube.com/watch?v=abc123DEF45", "/tmp")

Expand Down