fix(ci): remove unverified Syft download in SBOM workflow#58
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbitChores
WalkthroughGitHub Actions 워크플로우에서 Syft 바이너리 다운로드 및 직접 실행 단계를 제거하고, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/sbom.yml:
- Around line 42-46: The SBOM step using
anchore/sbom-action@57aae528053a48a3f6235f2d9461b05fbcb7366d currently relies on
its defaults which enable upload-artifact and upload-release-assets; disable
these automatic uploads by adding explicit inputs upload-artifact: false and
upload-release-assets: false to the anchore/sbom-action invocation (the block
containing uses: anchore/sbom-action@57aae528053a48a3f6235f2d9461b05fbcb7366d
and with: path/format/output-file) so the workflow stops duplicating uploads
that are already handled by the separate actions/upload-artifact and gh release
upload steps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d03cfee2-e052-4131-99c9-4b244834fa36
📒 Files selected for processing (1)
.github/workflows/sbom.yml
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai resolve |
✅ Actions performedReview triggered.
|
✅ Actions performedComments resolved and changes approved. |
Motivation
contents: write, creating a supply-chain risk if the release or transport were tampered with.Description
curl+tarinstallation and execution of Syft from.github/workflows/sbom.ymland replaced SBOM generation with the pinned actionanchore/sbom-action@57aae528053a48a3f6235f2d9461b05fbcb7366d.bandscope-sbom.cdx.jsonartifact still produced and uploaded).Testing
python3 scripts/checks/verify_supply_chain.pywhich passed successfully, validating the supply-chain baseline after the workflow update.Codex Task
📝 Walkthrough
Walkthrough
GitHub Actions 워크플로우에서 Syft 도구의 명시적 설치 및 CLI 직접 호출을 전담 GitHub Action(anchore/sbom-action)으로 대체하여 CycloneDX SBOM을 생성합니다. 기존 다운로드 및 추출 단계는 제거되고 새로운 단계가 실행됩니다.
Changes
.github/workflows/sbom.ymlanchore/sbom-actionGitHub Action으로 대체. CycloneDX JSON 형식으로 SBOM 생성 자동화 구성. 업로드 단계는 유지.Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem