fix: include workflow files in secret scan gate#60
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit릴리스 노트
Walkthrough시크릿 스캔 게이트 워크플로우의 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/secret-scan-gate.yml:
- Line 24: Update the regex fragment "BEGIN (R[S]A|E[C]|OPENS[S]H|PGP) PRIVATE
KEY" used in the git grep command so "PGP" uses the same self-match-avoidance
technique as the others — change "PGP" to "P[G]P" (i.e., "BEGIN
(R[S]A|E[C]|OPENS[S]H|P[G]P) PRIVATE KEY") so the pattern remains functionally
identical but consistent with the other character-class substitutions; ensure
the surrounding command and negation operator (!) are left unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 788069ab-3019-4314-96b6-002a5903255f
📒 Files selected for processing (1)
.github/workflows/secret-scan-gate.yml
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Motivation
.github/workflows/**created a blind spot that could allow credentials in workflow files to bypass the hardcoded-secret gate.Description
.github/workflows/secret-scan-gate.ymlso.github/workflows/**is scanned again and updated the hardcoded-secret regex literals to safe character-class forms to avoid self-matching while preserving detection behavior (g[h]p_,A[K]IA,A[I]za,R[S]A,E[C],OPENS[S]H)..github/workflows/secret-scan-gate.ymland the scan still excludespackage-lock.jsonandnode_modules/**to limit expected false positives.Testing
git grep -nE '(g[h]p_|g[h]o_|A[K]IA[0-9A-Z]{16}|A[I]za[0-9A-Za-z\-_]{35}|BEGIN (R[S]A|E[C]|OPENS[S]H|PGP) PRIVATE KEY)' -- . ':(exclude)package-lock.json' ':(exclude)node_modules/**'scan which returned exit code 1 indicating no matches in the current tree.python3 scripts/checks/verify_supply_chain.pywhich completed successfully and reported the supply-chain verification passed.Codex Task
📝 Walkthrough
Walkthrough
시크릿 스캔 게이트 워크플로우의 git grep 명령이 수정되었습니다. 정규식 패턴이 괄호 문자 클래스를 사용하도록 변경되고, 경로 제외 규칙이 단순화되었습니다.
.github/workflows/**제외 규칙이 제거되었습니다.Changes
.github/workflows/secret-scan-gate.ymlg[h]p_,A[K]IA)로 변경하고, 경로 제외 규칙을 단순화(.github/workflows/**제외 제거)Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Poem