🛡️ Sentinel: [CRITICAL] Fix path traversal in exportGherkin#47
🛡️ Sentinel: [CRITICAL] Fix path traversal in exportGherkin#47seonghobae wants to merge 1 commit into
Conversation
- Fixed path traversal in \`src/export/gherkin.ts\` which allowed writing files outside the project boundary via \`output\`. - Implemented boundary check via \`path.resolve\` and \`path.relative\`. - Added unit test in \`tests/gherkin.test.ts\` to verify \`exportGherkin\` safely throws \`INVALID_ARGUMENT\` when traversing outside. - Updated \`.jules/sentinel.md\` with findings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 47 minutes and 56 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
🚨 Severity: CRITICAL
💡 Vulnerability: The
exportGherkincommand allowed path traversal via theoutputparameter by naively constructing paths usingjoin, making it possible to write files outside of the project root.🎯 Impact: This allows arbitrary file overwrite outside the project structure, which could lead to critical system files or configurations being tampered with.
🔧 Fix: Updated
exportGherkinto construct an absolute path usingpath.resolveand correctly verify boundary conditions usingpath.relative. The code now throws aVspecErrorwithINVALID_ARGUMENTif the relative path escapes the project root or is absolute.✅ Verification: Covered with a path traversal test within a
vitestunit test undertests/gherkin.test.ts, confirmingVspecErrorgets thrown as expected. Runpnpm testandpnpm typecheckto verify overall correctness.PR created automatically by Jules for task 8759389234773059014 started by @seonghobae