🛡️ Sentinel: [CRITICAL] 파일 다운로드/내보내기 시 경로 순회 취약점 수정

[seonghobae]

🚨 Severity: CRITICAL
💡 Vulnerability: vspec gherkin <key> --output <path> 명령어에서 output 인자에 대한 경로 검증이 누락되어 있었습니다. 악의적인 에이전트가 ../../../../tmp/pwned.feature 와 같은 경로를 입력하면 프로젝트 루트 외부의 임의의 위치에 파일을 쓸 수 있는 Path Traversal 취약점이 존재했습니다.
🎯 Impact: 공격자가 시스템의 다른 중요한 파일을 덮어쓰거나 권한 밖의 디렉토리에 접근할 수 있습니다.
🔧 Fix: node:path의 resolve와 relative, isAbsolute 및 sep을 사용하여 최종 출력 경로가 config.root 내부에 안전하게 위치하는지 검증하도록 수정했습니다. 외부로 벗어날 경우 VspecError를 던집니다.
✅ Verification:

• tests/gherkin.test.ts에 악의적인 output 페이로드를 전달하여 에러가 정상적으로 발생하는지 확인하는 테스트를 추가했습니다. (pnpm test)

---

PR created automatically by Jules for task 11708360610657612910 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cacdee43-7d99-418a-b553-fc228cb6e76b

📥 Commits

Reviewing files that changed from the base of the PR and between f4223cb and 53cdb37.

📒 Files selected for processing (3)

• .jules/sentinel.md
• src/export/gherkin.ts
• tests/gherkin.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel/fix-path-traversal-gherkin-export-11708360610657612910

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch sentinel/fix-path-traversal-gherkin-export-11708360610657612910

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}