🛡️ Sentinel: [CRITICAL] 경로 탐색 취약점 수정 (Gherkin 내보내기)#57
Conversation
Fixed a critical path traversal vulnerability in `src/export/gherkin.ts` where a user-provided `--output` path was directly joined with the project root and written to. This allowed an attacker to write files outside the project root by providing paths like `../../tmp/hacked.txt`. The fix constructs an absolute path using `path.resolve` and verifies that the resulting path is safely contained within the configuration root by checking `path.relative` boundaries. If the path escapes the root, it throws a custom `VspecError` with a clean error message for the CLI.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 58 minutes and 37 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Path traversal in
exportGherkindue to unsafe use ofpath.joinwith user-provided output paths.🎯 Impact: An attacker or erroneous input could overwrite critical system files or write to unauthorized directories outside the project root (e.g.,
../../tmp/hacked.txt).🔧 Fix: Changed the path construction to use
path.resolve(config.root, output)and added strict boundary validation usingpath.relativeto ensure the output path remains within the configuration root. Throws aVspecErrorif an escape attempt is detected.✅ Verification: Verified by unit tests and manually confirmed that attempting to write to
../../tmp/...throws an error.PR created automatically by Jules for task 14279599182408464543 started by @seonghobae