🛡️ Sentinel: [CRITICAL] 경로 탐색 취약점 수정 (Fix path traversal in exportGherkin)#64
🛡️ Sentinel: [CRITICAL] 경로 탐색 취약점 수정 (Fix path traversal in exportGherkin)#64seonghobae wants to merge 1 commit into
Conversation
The `--output` argument in `vspec export gherkin` was previously joined directly with the root path, making it susceptible to path traversal via `../` escape sequences. This change introduces an absolute path resolution and a boundary check to throw a `VspecError` before generating files if the path traverses outside the repository root. A test case is included to verify this behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 30 minutes and 50 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The
--outputargument in theexportGherkinfunction was vulnerable to path traversal (e.g. escaping with../../).🎯 Impact: An attacker could overwrite arbitrary system files using the local execution privileges of the CLI.
🔧 Fix: Replaced naive
path.joinwithpath.resolveand verified boundaries withpath.relativechecking against..,../(path.sep), and absolute paths.✅ Verification: Added a test in
tests/gherkin.test.tsto ensure it throws aVspecErrorwithINVALID_ARGUMENT. Runpnpm testto verify.The patch includes the code change, test assertion, and updates the
.jules/sentinel.mdjournal per protocol.PR created automatically by Jules for task 1397667379910756392 started by @seonghobae