Skip to content

Clamp the skip fade to the outgoing track's remaining audio #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanylax2 wants to merge 1 commit into from
Closed

Clamp the skip fade to the outgoing track's remaining audio #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Packages/ContinuityKit/Sources/Playback/Player+Transport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,13 @@ extension Player {
// transition, just started now. finishTransition records the history step (and,
// because transitionIsSkip is set, does NOT earn the skip back — a skip is a spend).
// A second tap mid-blend, a paused player, or a one-track queue hard-cuts as before.
if isPlaying, !isTransitioning, queue.count > 1 {
activeTransitionDuration = Player.skipCrossfadeDuration
// Clamp the fade to the audio actually LEFT on the outgoing track: a 5 s blend with
// only 4 s of outgoing audio ends in the file draining at ~30% gain — an audible hard
// cut instead of a fade (short tracks / hot endings). Under a second remaining isn't
// enough to read as a blend at all — hard-cut instead.
let remaining = effectiveEndSeconds - position
if isPlaying, !isTransitioning, queue.count > 1, remaining > 1 {
activeTransitionDuration = min(Player.skipCrossfadeDuration, remaining)
transitionIsSkip = true
beginTransition(toIndex: target, outgoingPosition: position)
persistState()
Expand Down
Loading