Skip to content

Clamp the skip fade to the outgoing track's remaining audio #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanylax0 merged 1 commit into from
Jul 19, 2026
Merged

Clamp the skip fade to the outgoing track's remaining audio #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Packages/ContinuityKit/Sources/Playback/Player+Transport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,21 @@ extension Player {
startTimer()
}
resumeAfterInterruption = false
// Clamp the fade to the audio actually LEFT on the outgoing track: a 5 s blend with
// only 4 s of outgoing audio ends in the file draining at ~30% gain — an audible hard
// cut instead of a fade (short tracks / hot endings). Under a second remaining isn't
// enough to read as a blend at all — hard-advance instead.
let remaining = effectiveEndSeconds - position
guard remaining > 1 else {
currentIndex = targetIndex
startCurrentFresh()
persistState()
return
}
beginTransition(
toIndex: targetIndex,
outgoingPosition: position,
duration: Player.skipTransitionDurationSeconds,
duration: min(Player.skipTransitionDurationSeconds, remaining),
isUserInitiatedSkip: true
)
persistState()
Expand Down
Loading