Strip YouTube/Spotify ingest code and YouTubeKit from the App Store line - #114
Merged
Merged
Conversation
…line Ports the intent of PR #104 (appStoreReleaseCandidate) onto the current release line, rewritten against today's code so none of main's later stability fixes are regressed. Replaces the RemoteAudioIngest runtime gate with actual code removal: - Drop YouTubeKit from Package.swift; delete the resolvers (YouTube stream/playlist/search/oEmbed, Spotify), AudioDownloader, Retry, PreparationQueue import/sync extensions, and the gate itself. - PreparationQueue keeps local import, launch-time healing, analysis backfill, and demand-driven stems; interrupted/missing-audio tracks land in .failed. - App layer: AddMusicView is local-files only; RootView drops URL-scheme/ share/clipboard link handling; library/playlist sync UI removed; failed tracks show a plain warning badge. - Track gains stemKey (youtubeVideoID ?? id.uuidString) and the stems pipeline is rekeyed on it, so locally imported tracks get stem separation and vocal-aware transitions (previously YouTube-only). - LibraryCleanup: launch sweep now references audio by exact relative path and stems by stemKey — before, it deleted every locally imported audio file at next launch (their UUID filenames never matched a youtubeVideoID). Delete-time cleanup handles local files too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sanylax0
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #111. Ports the intent of #104 (
appStoreReleaseCandidate) onto the current release line — #104 itself branched from an older main and would regress the jetsam/interruption fixes if merged, so this is a manual rewrite against today's code. With this, the reviewed binary contains no YouTube scraping code at all, instead of dead-coding it behindRemoteAudioIngest.isEnabled.What's removed
PreparationQueue+Import/+Sync, LinkImporter, and theRemoteAudioIngestgate itself.What's kept / fixed
Track.stemKey(youtubeVideoID ?? id.uuidString), with the stems pipeline rekeyed on it — locally imported tracks now get stem separation and vocal-aware transitions, which were silently YouTube-only before.youtubeVideoID) — this explains imports vanishing between launches. It now references audio by exact relative path and stems bystemKey; delete-time cleanup handles local files too.Verification
xcodegen generate+ simulator build succeed; no YouTubeKit in the generated project. The two Swift-6-mode concurrency warnings inPreparationQueue+Stemsare pre-existing (identical code on the base branch).🤖 Generated with Claude Code