Repository navigation
Match gradient bleed to composited backdrop edge (fix page-boundary seam) - #128
Merged
Merged
Conversation
…nsion colors) The PagerBackdrop neighbor extensions used the raw palette endpoints, but AlbumBackdrop composites its gradient with a black scrim (0.30 top / 0.35 bottom), so the bleed abutted a darker rendered edge -> visible seam at the page boundary. Darken the extension endpoints by the matching scrim factors via a new private Color.darkened(by:) helper. Now-playing band unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0152PJuDNPYYxd7SDm4TSvbV
jaasthisenna-jpg
marked this pull request as ready for review
July 21, 2026 07:21
jaasthisenna-jpg
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the merged gradient-bleed feature (#127). A visible hard-edge/seam remained where the now-playing album backdrop meets the bleed extensions in the Library/Queue pages: the backdrop darkens its edges with a black scrim (0.30 top / 0.35 bottom) plus a 55% blurred-art overlay, but the bleed extensions were drawing the RAW un-scrimmed palette colors — so the bleed read lighter/different than the backdrop edge, producing a brightness jump.
Fix
Darken the bleed extension boundary colors by the same scrim factors (top 0.30 / bottom 0.35) via a new private
Color.darkened(by:)helper, so the extension meets the composited backdrop edge. The bottom boundary is an exact match (no art there); the top is a close approximation (a faint blurred-art texture the flat extension can't fully reproduce may remain — see Testing). The now-playing screen is pixel-identical (only the extension endpoint colors changed; geometry and the AlbumBackdrop band are untouched).File changed:
App/Continuity/Views/MainPagerView.swift.Testing
App-target SwiftUI can't be compiled on Linux CI (only ContinuityCore is Linux-testable); validated by review. Device verification pending — specifically dark mode (primary) is targeted; light mode (near-white systemGroupedBackground) and the faint top-edge art residual should be checked on device.
Slack thread: https://continuity-org.slack.com/archives/C0BCTF2C5NK/p1784611489906939
Generated by Claude Code