Repository navigation
Order onnxruntime embed-removal script after codesign - #139
Merged
Merged
Conversation
The 'Remove embedded static onnxruntime' post-build script declares no inputs, so the build system may run it concurrently with the framework signing task. When the delete lands mid-sign the build fails with "CodeSign failed ... onnxruntime.framework: No such file or directory". Declare each stub framework's _CodeSignature/CodeResources as an input file so the delete is sequenced after signing completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Remove embedded static onnxruntime post-build script declares no input files, so Xcode's build system is free to schedule it concurrently with the
Sign onnxruntime.frameworktask. When the delete lands mid-sign, the build fails:Reproduced on a local device build (Xcode 26 / iOS 26.5 SDK); the retry built clean — it's a scheduling race, so CI has been winning it by luck.
Fix
Declare each stub framework's
_CodeSignature/CodeResourcesas aninputFilesentry on the script phase, creating a dependency edge that sequences the delete after signing completes.basedOnDependencyAnalysis: falseis unchanged, so the script still runs every build.Verified
xcodegen generateemits the expectedinputPathsin the generated phase.🤖 Generated with Claude Code